Skip to content

fix(l1): fix tooling/sync sync target so it uses existing target #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2025
Merged

fix(l1): fix tooling/sync sync target so it uses existing target #4811

merged 3 commits into from
Oct 13, 2025

Conversation

@cdiielsi
Copy link
Contributor

@cdiielsi cdiielsi commented Oct 8, 2025 •
edited
Loading

Motivation

When running make sync in tooling/sync you get the following error:

make start-ethrex-hoodi >> ./logs/ethrex-sync-hoodi-levm.log
make[1]: *** No rule to make target `start-ethrex-hoodi'.  Stop.
make: *** [sync] Error 2

Because the specific start-ethrex-hoodi target no longer exists since this pr.

Description

Change start-ethrex-$(NETWORK) to start-ethrex in sync target as it was intended to be used since pr

@github-actions github-actions bot added the L1 Ethereum client label Oct 8, 2025
@cdiielsi cdiielsi marked this pull request as ready for review October 8, 2025 18:59
@cdiielsi cdiielsi requested a review from a team as a code owner October 8, 2025 18:59
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 8, 2025
MegaRedHand
MegaRedHand approved these changes Oct 9, 2025
View reviewed changes
@cdiielsi cdiielsi added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 315246a Oct 13, 2025
31 checks passed
@cdiielsi cdiielsi deleted the tooling/sync-fix-on-target-sync branch October 13, 2025 19:13
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@cdiielsi cdiielsi

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdiielsi @mpaulucci @MegaRedHand