---
.../components/__tests__/add-todo.test.tsx | 13 ++--
.../app/lib/__tests__/todo-context.test.tsx | 68 +++++++------------
apps/todo-app/app/lib/todo-context.tsx | 17 ++---
apps/todo-app/app/routes/create-todo.tsx | 6 +-
packages/ui/src/components/ui/button.test.tsx | 1 -
packages/ui/test/setup.ts | 1 -
packages/ui/vitest.config.ts | 1 -
packages/utils/src/cn.test.ts | 1 -
packages/utils/src/types.test.ts | 2 +-
packages/utils/vitest.config.ts | 1 -
10 files changed, 39 insertions(+), 72 deletions(-)
diff --git a/apps/todo-app/app/components/__tests__/add-todo.test.tsx b/apps/todo-app/app/components/__tests__/add-todo.test.tsx
index 56af780..d2e7538 100644
--- a/apps/todo-app/app/components/__tests__/add-todo.test.tsx
+++ b/apps/todo-app/app/components/__tests__/add-todo.test.tsx
@@ -2,13 +2,16 @@ import { render, screen, fireEvent } from '@testing-library/react';
import { describe, it, expect, vi } from 'vitest';
import { AddTodo } from '../add-todo';
+// Hoist regex to top-level to satisfy performance rule
+const addRegex = /add/i;
+
describe('AddTodo', () => {
it('renders input and button', () => {
const mockOnAdd = vi.fn();
render();
expect(screen.getByPlaceholderText('Add a new todo...')).toBeInTheDocument();
- expect(screen.getByRole('button', { name: /add/i })).toBeInTheDocument();
+ expect(screen.getByRole('button', { name: addRegex })).toBeInTheDocument();
});
it('calls onAdd when form is submitted with text', () => {
@@ -16,7 +19,7 @@ describe('AddTodo', () => {
render();
const input = screen.getByPlaceholderText('Add a new todo...');
- const button = screen.getByRole('button', { name: /add/i });
+ const button = screen.getByRole('button', { name: addRegex });
fireEvent.change(input, { target: { value: 'New todo' } });
fireEvent.click(button);
@@ -29,7 +32,7 @@ describe('AddTodo', () => {
render();
const input = screen.getByPlaceholderText('Add a new todo...') as HTMLInputElement;
- const button = screen.getByRole('button', { name: /add/i });
+ const button = screen.getByRole('button', { name: addRegex });
fireEvent.change(input, { target: { value: 'New todo' } });
fireEvent.click(button);
@@ -41,7 +44,7 @@ describe('AddTodo', () => {
const mockOnAdd = vi.fn();
render();
- const button = screen.getByRole('button', { name: /add/i });
+ const button = screen.getByRole('button', { name: addRegex });
fireEvent.click(button);
expect(mockOnAdd).not.toHaveBeenCalled();
@@ -52,7 +55,7 @@ describe('AddTodo', () => {
render();
const input = screen.getByPlaceholderText('Add a new todo...');
- const button = screen.getByRole('button', { name: /add/i });
+ const button = screen.getByRole('button', { name: addRegex });
fireEvent.change(input, { target: { value: ' New todo ' } });
fireEvent.click(button);
diff --git a/apps/todo-app/app/lib/__tests__/todo-context.test.tsx b/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
index b07b388..b3acc2f 100644
--- a/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
+++ b/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
@@ -12,16 +12,7 @@ Object.defineProperty(global, 'crypto', {
// Test component to access the context
function TestComponent() {
- const {
- todos,
- filter,
- addTodo,
- toggleTodo,
- deleteTodo,
- updateTodo,
- setFilter,
- clearCompleted
- } = useTodoStore();
+ const { todos, filter, addTodo, toggleTodo, deleteTodo, updateTodo, setFilter, clearCompleted } = useTodoStore();
return (
@@ -30,22 +21,13 @@ function TestComponent() {
-
-
+
diff --git a/packages/ui/src/components/ui/button.test.tsx b/packages/ui/src/components/ui/button.test.tsx
index fec9e6a..889a937 100644
--- a/packages/ui/src/components/ui/button.test.tsx
+++ b/packages/ui/src/components/ui/button.test.tsx
@@ -60,4 +60,3 @@ describe('buttonVariants', () => {
expect(classes).toContain('px-3');
});
});
-
diff --git a/packages/ui/test/setup.ts b/packages/ui/test/setup.ts
index adee3c8..7b0828b 100644
--- a/packages/ui/test/setup.ts
+++ b/packages/ui/test/setup.ts
@@ -1,2 +1 @@
import '@testing-library/jest-dom';
-
diff --git a/packages/ui/vitest.config.ts b/packages/ui/vitest.config.ts
index f8ea910..c6c470b 100644
--- a/packages/ui/vitest.config.ts
+++ b/packages/ui/vitest.config.ts
@@ -9,4 +9,3 @@ export default defineConfig({
setupFiles: ['./test/setup.ts']
}
});
-
diff --git a/packages/utils/src/cn.test.ts b/packages/utils/src/cn.test.ts
index b4176bf..c18288f 100644
--- a/packages/utils/src/cn.test.ts
+++ b/packages/utils/src/cn.test.ts
@@ -32,4 +32,3 @@ describe('cn utility function', () => {
expect(result).toBe('class1 class2 class3');
});
});
-
diff --git a/packages/utils/src/types.test.ts b/packages/utils/src/types.test.ts
index f50efd6..af41fc4 100644
--- a/packages/utils/src/types.test.ts
+++ b/packages/utils/src/types.test.ts
@@ -20,7 +20,7 @@ describe('Todo types', () => {
it('should accept valid TodoFilter values', () => {
const filters: TodoFilter[] = ['all', 'active', 'completed'];
-
+
filters.forEach(filter => {
expect(['all', 'active', 'completed']).toContain(filter);
});
diff --git a/packages/utils/vitest.config.ts b/packages/utils/vitest.config.ts
index f9395cf..414d975 100644
--- a/packages/utils/vitest.config.ts
+++ b/packages/utils/vitest.config.ts
@@ -6,4 +6,3 @@ export default defineConfig({
environment: 'node'
}
});
-
From 1bb8154d019e014346dae924dbe9f6d94b36212b Mon Sep 17 00:00:00 2001
From: "codegen-sh[bot]" <131295404+codegen-sh[bot]@users.noreply.github.com>
Date: Fri, 8 Aug 2025 21:15:11 +0000
Subject: [PATCH 12/55] test(utils): simplify boolean logic in cn.test to
satisfy biome rule\n\nCo-authored-by: Jake Ruesink
---
packages/utils/src/cn.test.ts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/packages/utils/src/cn.test.ts b/packages/utils/src/cn.test.ts
index c18288f..d72b990 100644
--- a/packages/utils/src/cn.test.ts
+++ b/packages/utils/src/cn.test.ts
@@ -1,6 +1,10 @@
import { describe, it, expect } from 'vitest';
import { cn } from './cn';
+// Simplified boolean logic for linter
+const truthy = 'conditional-class';
+const falsy = false as const;
+
describe('cn utility function', () => {
it('should combine class names correctly', () => {
const result = cn('text-red-500', 'bg-blue-100');
@@ -8,7 +12,7 @@ describe('cn utility function', () => {
});
it('should handle conditional classes', () => {
- const result = cn('base-class', true && 'conditional-class', false && 'hidden-class');
+ const result = cn('base-class', truthy, falsy && 'hidden-class');
expect(result).toBe('base-class conditional-class');
});
From 5279de1438e190cde295a87396c9c22a45e15b6d Mon Sep 17 00:00:00 2001
From: "codegen-sh[bot]" <131295404+codegen-sh[bot]@users.noreply.github.com>
Date: Fri, 8 Aug 2025 21:16:21 +0000
Subject: [PATCH 13/55] test(utils): remove void expressions; use no-op
functions with explicit returns\n\nCo-authored-by: Jake Ruesink
---
packages/utils/src/types.test.ts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/packages/utils/src/types.test.ts b/packages/utils/src/types.test.ts
index af41fc4..b6e6337 100644
--- a/packages/utils/src/types.test.ts
+++ b/packages/utils/src/types.test.ts
@@ -31,12 +31,12 @@ describe('Todo types', () => {
const mockStore: TodoStore = {
todos: [],
filter: 'all',
- addTodo: (text: string) => void 0,
- toggleTodo: (id: string) => void 0,
- deleteTodo: (id: string) => void 0,
- updateTodo: (id: string, text: string) => void 0,
- setFilter: (filter: TodoFilter) => void 0,
- clearCompleted: () => void 0
+ addTodo: (_text: string) => { return; },
+ toggleTodo: (_id: string) => { return; },
+ deleteTodo: (_id: string) => { return; },
+ updateTodo: (_id: string, _text: string) => { return; },
+ setFilter: (_filter: TodoFilter) => { return; },
+ clearCompleted: () => { return; }
};
expect(mockStore.todos).toEqual([]);
From 5985235afbff7944c30aa376c80dadd1d59405f9 Mon Sep 17 00:00:00 2001
From: "codegen-sh[bot]" <131295404+codegen-sh[bot]@users.noreply.github.com>
Date: Fri, 8 Aug 2025 21:17:17 +0000
Subject: [PATCH 14/55] test(todo-context): satisfy biome rules (button type,
no-op console.error body)\n\nCo-authored-by: Jake Ruesink
---
.../app/lib/__tests__/todo-context.test.tsx | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/apps/todo-app/app/lib/__tests__/todo-context.test.tsx b/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
index b3acc2f..2801a65 100644
--- a/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
+++ b/apps/todo-app/app/lib/__tests__/todo-context.test.tsx
@@ -18,22 +18,22 @@ function TestComponent() {
{todos.length}
{filter}
-
)}
-
+