fix(reporter): reject non-positive CHECK_INTERVAL and HEARTBEAT_PERIOD (#367)

Author: DsThakurRawat

cmd/readiness-condition-reporter/main.go

@@ -55,6 +55,21 @@ type HealthResponse struct {
 	Message string `json:"message"`
 }
 
+func parseDurationWithDefault(input string, defaultVal time.Duration, name string) time.Duration {
+	if input == "" {
+		return defaultVal
+	}
+	parsed, err := time.ParseDuration(input)
+	if err != nil || parsed <= 0 {
+		klog.ErrorS(err, "Invalid duration, using default",
+			"setting", name,
+			"input", input,
+			"default", defaultVal)
+		return defaultVal
+	}
+	return parsed
+}
+
 func main() {
 	klog.InitFlags(nil)
 	flag.Parse()
@@ -82,31 +97,8 @@ func main() {
 		os.Exit(1)
 	}
 
-	checkInterval := os.Getenv(envCheckInterval)
-	interval := defaultCheckInterval
-	if checkInterval != "" {
-		parsedInterval, err := time.ParseDuration(checkInterval)
-		if err == nil {
-			interval = parsedInterval
-		} else {
-			klog.ErrorS(err, "Failed to parse check interval, using default",
-				"input", checkInterval,
-				"default", defaultCheckInterval)
-		}
-	}
-
-	heartbeatPeriodStr := os.Getenv(envHeartbeatPeriod)
-	heartbeatPeriod := defaultHeartbeatPeriod
-	if heartbeatPeriodStr != "" {
-		parsedPeriod, err := time.ParseDuration(heartbeatPeriodStr)
-		if err == nil {
-			heartbeatPeriod = parsedPeriod
-		} else {
-			klog.ErrorS(err, "Failed parse heartbeat period, using default",
-				"input", heartbeatPeriodStr,
-				"default", defaultHeartbeatPeriod)
-		}
-	}
+	interval := parseDurationWithDefault(os.Getenv(envCheckInterval), defaultCheckInterval, "check interval")
+	heartbeatPeriod := parseDurationWithDefault(os.Getenv(envHeartbeatPeriod), defaultHeartbeatPeriod, "heartbeat period")
 
 	// Create Kubernetes client
 	config, err := rest.InClusterConfig()

cmd/readiness-condition-reporter/main_test.go

@@ -267,3 +267,48 @@ func TestUpdateNodeCondition(t *testing.T) {
 		})
 	}
 }
+
+func TestParseDurationWithDefault(t *testing.T) {
+	defaultVal := 30 * time.Second
+
+	tests := []struct {
+		name     string
+		input    string
+		expected time.Duration
+	}{
+		{
+			name:     "valid positive duration",
+			input:    "60s",
+			expected: 60 * time.Second,
+		},
+		{
+			name:     "zero duration",
+			input:    "0s",
+			expected: defaultVal,
+		},
+		{
+			name:     "negative duration",
+			input:    "-30s",
+			expected: defaultVal,
+		},
+		{
+			name:     "unparseable duration",
+			input:    "abc",
+			expected: defaultVal,
+		},
+		{
+			name:     "empty duration",
+			input:    "",
+			expected: defaultVal,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := parseDurationWithDefault(tt.input, defaultVal, "test duration")
+			if result != tt.expected {
+				t.Errorf("parseDurationWithDefault(%q) = %v, expected %v", tt.input, result, tt.expected)
+			}
+		})
+	}
+}