diff --git a/cmd/epp/runner/runner.go b/cmd/epp/runner/runner.go index 24a59ebf7..7bc27103c 100644 --- a/cmd/epp/runner/runner.go +++ b/cmd/epp/runner/runner.go @@ -139,8 +139,9 @@ var ( configFile = flag.String("config-file", runserver.DefaultConfigFile, "The path to the configuration file") configText = flag.String("config-text", runserver.DefaultConfigText, "The configuration specified as text, in lieu of a file") - modelServerMetricsPort = flag.Int("model-server-metrics-port", 0, "Port to scrape metrics from pods. "+ - "Default value will be set to the InferencePool.Spec.TargetPorts[0].Number if not set.") + modelServerMetricsPort = flag.Int("model-server-metrics-port", 0, "[DEPRECATED] Port to scrape metrics from pods. "+ + "Default value will be set to the InferencePool.Spec.TargetPorts[0].Number if not set."+ + "This option will be removed in the next release.") modelServerMetricsPath = flag.String("model-server-metrics-path", "/metrics", "Path to scrape metrics from pods") modelServerMetricsScheme = flag.String("model-server-metrics-scheme", "http", "Scheme to scrape metrics from pods") modelServerMetricsHttpsInsecureSkipVerify = flag.Bool("model-server-metrics-https-insecure-skip-verify", true, "When using 'https' scheme for 'model-server-metrics-scheme', configure 'InsecureSkipVerify' (default to true)") @@ -198,6 +199,8 @@ func (r *Runner) Run(ctx context.Context) error { flag.Parse() initLogging(&opts) + r.deprecatedFlagsHandler(setupLog) + if *tracing { err := common.InitTracing(ctx, setupLog) if err != nil { @@ -486,6 +489,14 @@ func (r *Runner) parseConfigurationPhaseTwo(ctx context.Context, rawConfig *conf return cfg, nil } +func (r *Runner) deprecatedFlagsHandler(logger logr.Logger) { + flag.Visit(func(f *flag.Flag) { + if f.Name == "model-server-metrics-port" { // future: use map/set to store deprecated flags (and replacements?) + logger.Info("deprecated option will be removed in the next release.", "option", f.Name) + } + }) +} + func (r *Runner) deprecatedConfigurationHelper(cfg *config.Config, logger logr.Logger) { // Handle deprecated environment variable based feature flags diff --git a/pkg/epp/datastore/datastore.go b/pkg/epp/datastore/datastore.go index 2ab2e98cb..d4f14b974 100644 --- a/pkg/epp/datastore/datastore.go +++ b/pkg/epp/datastore/datastore.go @@ -68,6 +68,8 @@ type Datastore interface { Clear() } +// NewDatastore creates a new data store. +// TODO: modelServerMetricsPort is being deprecated func NewDatastore(parentCtx context.Context, epFactory datalayer.EndpointFactory, modelServerMetricsPort int32, opts ...DatastoreOption) Datastore { // Initialize with defaults store := &datastore{ @@ -100,7 +102,7 @@ type datastore struct { pods *sync.Map // modelServerMetricsPort metrics port from EPP command line argument // used only if there is only one inference engine per pod - modelServerMetricsPort int32 + modelServerMetricsPort int32 // TODO: deprecating epf datalayer.EndpointFactory }