Skip to content

Commit 730578c

Browse files
author
Yehudit Kerido
committed
feat: Update Node toolchain to version 24 for crud-web-apps
Signed-off-by: Yehudit Kerido <[email protected]>
1 parent 8c44fd7 commit 730578c

File tree

23 files changed

+10588
-56732
lines changed

23 files changed

+10588
-56732
lines changed

‎.github/workflows/common_frontend_tests.yaml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010
- notebooks-v1
1111

1212
env:
13+
NODE_VERSION: 24.11.1
1314
FRONTEND_DIR: components/crud-web-apps/common/frontend/kubeflow-common-lib
1415

1516
jobs:
@@ -27,7 +28,7 @@ jobs:
2728
- name: Setup Node
2829
uses: actions/setup-node@v4
2930
with:
30-
node-version: 16
31+
node-version: ${{ env.NODE_VERSION }}
3132

3233
- name: Install dependencies
3334
run: npm ci
@@ -48,10 +49,10 @@ jobs:
4849
- name: Checkout
4950
uses: actions/checkout@v4
5051

51-
- name: Setup node version to 16
52+
- name: Setup Node
5253
uses: actions/setup-node@v4
5354
with:
54-
node-version: 16
55+
node-version: ${{ env.NODE_VERSION }}
5556

5657
- name: Install Kubeflow common library dependencies
5758
run: npm ci

‎.github/workflows/jwa_frontend_tests.yaml‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ on:
99
- notebooks-v1
1010
- 'v*-branch'
1111

12+
env:
13+
NODE_VERSION: 24.11.1
14+
1215
jobs:
1316
frontend-format-linting-check:
1417
name: Check code format and lint
@@ -22,7 +25,7 @@ jobs:
2225
- name: Setup Node
2326
uses: actions/setup-node@v4
2427
with:
25-
node-version: 16
28+
node-version: ${{ env.NODE_VERSION }}
2629
- name: Install dependencies
2730
run: npm ci
2831
- name: Check frontend formatting
@@ -37,10 +40,10 @@ jobs:
3740
- name: Checkout
3841
uses: actions/checkout@v4
3942

40-
- name: Setup node version to 16
43+
- name: Setup Node
4144
uses: actions/setup-node@v4
4245
with:
43-
node-version: 16
46+
node-version: ${{ env.NODE_VERSION }}
4447

4548
- name: Install Kubeflow common library dependecies
4649
run: |
@@ -67,10 +70,10 @@ jobs:
6770
- name: Checkout
6871
uses: actions/checkout@v4
6972

70-
- name: Setup node version to 16
73+
- name: Setup Node
7174
uses: actions/setup-node@v4
7275
with:
73-
node-version: 16
76+
node-version: ${{ env.NODE_VERSION }}
7477

7578
- name: Install Kubeflow common library dependecies
7679
run: |

‎.github/workflows/twa_frontend_tests.yaml‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ on:
99
- v*-branch
1010
- notebooks-v1
1111

12+
env:
13+
NODE_VERSION: 24.11.1
14+
1215
jobs:
1316
frontend-format-linting-check:
1417
name: Code format and lint
@@ -21,10 +24,10 @@ jobs:
2124
- name: Checkout code
2225
uses: actions/checkout@v4
2326

24-
- name: Setup Node.js
27+
- name: Setup Node
2528
uses: actions/setup-node@v4
2629
with:
27-
node-version: 16
30+
node-version: ${{ env.NODE_VERSION }}
2831

2932
- name: Format tensorboards web app
3033
run: |
@@ -43,10 +46,10 @@ jobs:
4346
- name: Checkout code
4447
uses: actions/checkout@v4
4548

46-
- name: Setup node version to 16
49+
- name: Setup Node
4750
uses: actions/setup-node@v4
4851
with:
49-
node-version: 16
52+
node-version: ${{ env.NODE_VERSION }}
5053

5154
- name: Install common library dependencies
5255
run: |
@@ -73,10 +76,10 @@ jobs:
7376
- name: Checkout code
7477
uses: actions/checkout@v4
7578

76-
- name: Setup Node.js
79+
- name: Setup Node
7780
uses: actions/setup-node@v4
7881
with:
79-
node-version: 16
82+
node-version: ${{ env.NODE_VERSION }}
8083

8184
- name: Install common library dependencies
8285
run: |

‎.github/workflows/vwa_frontend_tests.yaml‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ on:
99
- notebooks-v1
1010
- 'v*-branch'
1111

12+
env:
13+
NODE_VERSION: 24.11.1
14+
1215
jobs:
1316
frontend-format-linting-check:
1417
name: Check code format and lint
@@ -22,7 +25,7 @@ jobs:
2225
- name: Setup Node
2326
uses: actions/setup-node@v4
2427
with:
25-
node-version: 16
28+
node-version: ${{ env.NODE_VERSION }}
2629
- name: Install dependencies
2730
run: npm ci
2831
- name: Check frontend formatting
@@ -37,10 +40,10 @@ jobs:
3740
- name: Checkout
3841
uses: actions/checkout@v4
3942

40-
- name: Setup node version to 16
43+
- name: Setup Node
4144
uses: actions/setup-node@v4
4245
with:
43-
node-version: 16
46+
node-version: ${{ env.NODE_VERSION }}
4447

4548
- name: Install Kubeflow common library dependecies
4649
run: |
@@ -64,10 +67,10 @@ jobs:
6467
- name: Checkout
6568
uses: actions/checkout@v4
6669

67-
- name: Setup node version to 16
70+
- name: Setup Node
6871
uses: actions/setup-node@v4
6972
with:
70-
node-version: 16
73+
node-version: ${{ env.NODE_VERSION }}
7174

7275
- name: Install Kubeflow common library dependecies
7376
run: |
@@ -96,10 +99,10 @@ jobs:
9699
- name: Checkout
97100
uses: actions/checkout@v4
98101

99-
- name: Setup node version to 16
102+
- name: Setup Node
100103
uses: actions/setup-node@v4
101104
with:
102-
node-version: 16
105+
node-version: ${{ env.NODE_VERSION }}
103106

104107
- name: Install Kubeflow common library dependecies
105108
run: |

‎components/crud-web-apps/common/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ You also need to add `"preserveSymlinks": true` to the app's frontend `angular.j
116116

117117
```dockerfile
118118
# --- Build the frontend kubeflow library ---
119-
FROM node:16 as frontend-kubeflow-lib
119+
FROM node:24 as frontend-kubeflow-lib
120120

121121
WORKDIR /src
122122

@@ -128,7 +128,7 @@ RUN npm run build
128128

129129
...
130130
# --- Build the frontend ---
131-
FROM node:16 as frontend
131+
FROM node:24 as frontend
132132
RUN npm install -g @angular/cli
133133

134134
WORKDIR /src

0 commit comments

Comments
 (0)