feat(notifications): improve hardware summary code (#1645)

- Send weekly hardware summary emails instead of only on failures

- Restrict notifications to production or dev environments

Signed-off-by: Yushan Li <[email protected]>

Author: ximiali

backend/kernelCI_app/management/commands/notifications.py

@@ -739,9 +739,12 @@ def generate_hardware_summary_report(
 ):
     """
     Generate weekly hardware reports for hardware submission file.
-    Emails are sent only for hardware with failed tests.
     """
 
+    if get_running_instance() == "staging":
+        print("This command only runs on production or dev environments.")
+        return
+
     now = datetime.now(timezone.utc)
     start_date = now - timedelta(days=7)
     end_date = now
@@ -759,10 +762,6 @@ def generate_hardware_summary_report(
         end_date=end_date,
     )
 
-    if not hardwares_data_raw:
-        print("No data for hardware summary")
-        return
-
     hardwares_data_dict = defaultdict(list)
     for raw in hardwares_data_raw:
         try:
@@ -786,11 +785,15 @@ def generate_hardware_summary_report(
     )
 
     # Iterate through each hardware record to render report, extract recipient, send email
-    for (hardware_id, origin), hardware_data in hardwares_data_dict.items():
+    for hardware_id, origin in hardware_key_set:
+        hardware_data = hardwares_data_dict.get((hardware_id, origin), [])
         hardware_raw = next(
             (row for row in hardwares_list_raw if row.get("platform") == hardware_id),
             None,
         )
+        if hardware_raw is None:
+            print(f"Hardware {hardware_id} not found in listing data")
+            continue
 
         hardware_item = sanitize_hardware(hardware_raw)
         build_status_group = group_status(hardware_item.build_status_summary)

docs/notifications.md

@@ -27,7 +27,7 @@ The command supports four primary actions:
 1. `summary`
     * Runs a checkout summary report for trees listed in the [subscriptions folder](../backend/data/notifications/subscriptions/).
 1. `hardware_summary`
-    * Generate weekly hardware reports for hardware listed in the [subscriptions folder](../backend/data/notifications/subscriptions/). Emails are sent only for hardware with failed tests.
+    * Generate weekly hardware reports for hardware listed in the [subscriptions folder](../backend/data/notifications/subscriptions/).
 1.  `fake_report`
     * Generates a fake report (for  testing email send).