Tighten profile refresh coverage and docs

Author: IlyaasK

docs/resources/browser_pool.md

@@ -31,7 +31,7 @@ Kernel browser pool durable configuration.
 - `project_id` (String) Project this browser pool belongs to. Defaults to the provider `project_id` when unset; when neither is set, the API key's project binding determines the project. Once created the pool keeps its project, and changing this attribute replaces the pool.
 - `proxy_id` (String) Optional proxy ID to use for browsers created by this pool.
 - `rebuild_idle_browsers_on_update` (Boolean) When true, changes to profile_id, proxy_id, extension_ids, chrome_policy, viewport, headless, kiosk_mode, stealth, or start_url discard browsers that are idle when the update runs so replacements use the new configuration. Browsers that are warming or currently leased are not rebuilt. Kernel does not store this provider-local setting, so imported browser pools default to false unless configured otherwise.
-- `refresh_on_profile_update` (Boolean) Controls whether idle browsers are refreshed when the pool's profile is updated. Requires `profile_id` when true. When omitted, Kernel chooses its profile-dependent default when a profile is attached, changed, or removed; the API value is stored in state and preserved during unrelated updates. Explicit true or false values are sent unchanged.
+- `refresh_on_profile_update` (Boolean) Controls whether idle browsers are refreshed when the pool's profile is updated. Requires `profile_id` when true. When omitted, Kernel chooses the applicable default when a profile is attached, changed, or removed; the API value is stored in state and preserved during unrelated updates. Explicit true or false values are sent unchanged.
 - `start_url` (String) Optional URL to navigate to when a browser is warmed into the pool.
 - `stealth` (Boolean) Launch browsers in stealth mode.
 - `timeout_seconds` (Number) Default idle timeout in seconds for acquired browsers.

internal/resources/browserpool/expand_test.go

@@ -19,6 +19,7 @@ func TestExpandCreateParamsMapsDurableConfigToSDK(t *testing.T) {
 		Name:              types.StringValue("pool-a"),
 		Size:              types.Int64Value(5),
 		ProfileID:         types.StringValue("profile-1"),
+		RefreshOnProfile:  types.BoolValue(false),
 		ProxyID:           types.StringValue("proxy-1"),
 		ExtensionIDs:      stringListForTest("ext-b", "ext-a"),
 		ChromePolicy:      chromePolicyValueForTest(`{"HomepageLocation":"https://example.com"}`),
@@ -38,19 +39,20 @@ func TestExpandCreateParamsMapsDurableConfigToSDK(t *testing.T) {
 
 	body := marshalSDKParams(t, params)
 	want := map[string]any{
-		"name":                 "pool-a",
-		"size":                 float64(5),
-		"profile":              map[string]any{"id": "profile-1"},
-		"proxy_id":             "proxy-1",
-		"extensions":           []any{map[string]any{"id": "ext-b"}, map[string]any{"id": "ext-a"}},
-		"chrome_policy":        map[string]any{"HomepageLocation": "https://example.com"},
-		"viewport":             map[string]any{"width": float64(1280), "height": float64(800), "refresh_rate": float64(60)},
-		"headless":             true,
-		"kiosk_mode":           true,
-		"stealth":              false,
-		"start_url":            "https://start.example",
-		"timeout_seconds":      float64(90),
-		"fill_rate_per_minute": float64(20),
+		"name":                      "pool-a",
+		"size":                      float64(5),
+		"profile":                   map[string]any{"id": "profile-1"},
+		"refresh_on_profile_update": false,
+		"proxy_id":                  "proxy-1",
+		"extensions":                []any{map[string]any{"id": "ext-b"}, map[string]any{"id": "ext-a"}},
+		"chrome_policy":             map[string]any{"HomepageLocation": "https://example.com"},
+		"viewport":                  map[string]any{"width": float64(1280), "height": float64(800), "refresh_rate": float64(60)},
+		"headless":                  true,
+		"kiosk_mode":                true,
+		"stealth":                   false,
+		"start_url":                 "https://start.example",
+		"timeout_seconds":           float64(90),
+		"fill_rate_per_minute":      float64(20),
 	}
 
 	if !jsonEqual(t, body, want) {
@@ -61,6 +63,7 @@ func TestExpandCreateParamsMapsDurableConfigToSDK(t *testing.T) {
 func TestExpandCreateParamsOmitsUnknownServerDefaults(t *testing.T) {
 	model := browserPoolModel{
 		Size:              types.Int64Value(1),
+		RefreshOnProfile:  types.BoolUnknown(),
 		Headless:          types.BoolUnknown(),
 		KioskMode:         types.BoolUnknown(),
 		Stealth:           types.BoolUnknown(),

internal/resources/browserpool/refresh_on_profile_update_plan_modifier.go

@@ -13,7 +13,7 @@ var _ planmodifier.Bool = preserveRefreshOnProfileUpdate{}
 type preserveRefreshOnProfileUpdate struct{}
 
 func (preserveRefreshOnProfileUpdate) Description(context.Context) string {
-	return "Preserves refresh_on_profile_update when the planned browser pool still has a profile."
+	return "Preserves refresh_on_profile_update when profile_id is unchanged."
 }
 
 func (m preserveRefreshOnProfileUpdate) MarkdownDescription(ctx context.Context) string {

internal/resources/browserpool/resource_acc_test.go

@@ -41,6 +41,7 @@ func TestAccBrowserPoolLifecycle(t *testing.T) {
 					resource.TestCheckResourceAttr(browserPoolResourceName, "headless", "true"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "kiosk_mode", "false"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "stealth", "false"),
+					resource.TestCheckResourceAttr(browserPoolResourceName, "refresh_on_profile_update", "false"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "timeout_seconds", "90"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "fill_rate_per_minute", "0"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "rebuild_idle_browsers_on_update", "true"),
@@ -55,6 +56,7 @@ func TestAccBrowserPoolLifecycle(t *testing.T) {
 					resource.TestCheckResourceAttr(browserPoolResourceName, "size", "1"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "start_url", "https://example.com/two"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "stealth", "true"),
+					resource.TestCheckResourceAttr(browserPoolResourceName, "refresh_on_profile_update", "false"),
 					resource.TestCheckResourceAttr(browserPoolResourceName, "rebuild_idle_browsers_on_update", "true"),
 					testAccCheckAcquiredBrowserStealth(t, browserPoolResourceName, true),
 				),

internal/resources/browserpool/schema.go

@@ -72,7 +72,7 @@ func BrowserPoolSchema() rschema.Schema {
 			"refresh_on_profile_update": rschema.BoolAttribute{
 				Optional:            true,
 				Computed:            true,
-				MarkdownDescription: "Controls whether idle browsers are refreshed when the pool's profile is updated. Requires `profile_id` when true. When omitted, Kernel chooses its profile-dependent default when a profile is attached, changed, or removed; the API value is stored in state and preserved during unrelated updates. Explicit true or false values are sent unchanged.",
+				MarkdownDescription: "Controls whether idle browsers are refreshed when the pool's profile is updated. Requires `profile_id` when true. When omitted, Kernel chooses the applicable default when a profile is attached, changed, or removed; the API value is stored in state and preserved during unrelated updates. Explicit true or false values are sent unchanged.",
 				PlanModifiers: []planmodifier.Bool{
 					preserveRefreshOnProfileUpdate{},
 				},

internal/resources/browserpool/schema_test.go

@@ -152,12 +152,20 @@ func TestSchemaRebuildIdleBrowsersOnUpdateDefaultsFalse(t *testing.T) {
 
 func TestSchemaRefreshOnProfileUpdatePreservesStateDuringUnrelatedUpdate(t *testing.T) {
 	attr := boolAttribute(t, BrowserPoolSchema(), "refresh_on_profile_update")
-	planned := runRefreshOnProfileUpdatePlanModifiers(t, attr,
-		types.BoolValue(false), types.BoolUnknown(), types.BoolNull(),
-		tftypes.NewValue(tftypes.String, "profile-1"), tftypes.NewValue(tftypes.String, "profile-1"))
+	tests := map[string]tftypes.Value{
+		"with profile":    tftypes.NewValue(tftypes.String, "profile-1"),
+		"without profile": tftypes.NewValue(tftypes.String, nil),
+	}
 
-	if !planned.Equal(types.BoolValue(false)) {
-		t.Fatalf("unset refresh_on_profile_update should keep the state value, got %v", planned)
+	for name, profileID := range tests {
+		t.Run(name, func(t *testing.T) {
+			planned := runRefreshOnProfileUpdatePlanModifiers(t, attr,
+				types.BoolValue(false), types.BoolUnknown(), types.BoolNull(), profileID, profileID)
+
+			if !planned.Equal(types.BoolValue(false)) {
+				t.Fatalf("unset refresh_on_profile_update should keep the state value, got %v", planned)
+			}
+		})
 	}
 }