Skip to content

Commit b74cae1

Browse files
feat: Auto-default refresh_on_profile_update when browser pool profile changes
1 parent fe39910 commit b74cae1

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

.stats.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
configured_endpoints: 127
2-
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/kernel/kernel-9143bc729ef60beffa0bbd9b601bb095083e41e23c8994553e69302f586882f5.yml
3-
openapi_spec_hash: bd04c530cfa8188af0e63a784129645d
2+
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/kernel/kernel-25b48b79d356843aeda41e5e5c3c407c5bd5c12f9548500ffc0a6696e6acd941.yml
3+
openapi_spec_hash: f710169690ab7aca30c91968e752cff7
44
config_hash: 77ee715aa17061166f9a02b264a21b8d

browserpool.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@ type BrowserPoolBrowserPoolConfig struct {
238238
// project as the browser session.
239239
ProxyID string `json:"proxy_id"`
240240
// When true, flush idle browsers when the profile the pool uses is updated, so
241-
// pool browsers pick up the latest profile data. Requires a profile to be set on
242-
// the pool.
241+
// pool browsers pick up the latest profile data. When a profile is provided during
242+
// creation, this defaults to true. Requires a profile to be set on the pool.
243243
RefreshOnProfileUpdate bool `json:"refresh_on_profile_update"`
244244
// Optional URL to navigate to when a new browser is warmed into the pool.
245245
// Best-effort: failures to navigate do not fail pool fill. Only applied to
@@ -439,8 +439,8 @@ type BrowserPoolNewParams struct {
439439
// the same project as the browser session.
440440
ProxyID param.Opt[string] `json:"proxy_id,omitzero"`
441441
// When true, flush idle browsers when the profile the pool uses is updated, so
442-
// pool browsers pick up the latest profile data. Requires a profile to be set on
443-
// the pool.
442+
// pool browsers pick up the latest profile data. When a profile is provided during
443+
// creation, this defaults to true. Requires a profile to be set on the pool.
444444
RefreshOnProfileUpdate param.Opt[bool] `json:"refresh_on_profile_update,omitzero"`
445445
// Optional URL to navigate to when a new browser is warmed into the pool.
446446
// Best-effort: failures to navigate do not fail pool fill. Only applied to
@@ -537,7 +537,10 @@ type BrowserPoolUpdateParams struct {
537537
// proxy unchanged.
538538
ProxyID param.Opt[string] `json:"proxy_id,omitzero"`
539539
// If provided, replaces whether idle browsers are flushed when the profile the
540-
// pool uses is updated. Requires a profile to be set on the pool.
540+
// pool uses is updated. When the pool's profile reference is changed (including
541+
// newly attached) and this field is omitted, it defaults to true. Re-sending the
542+
// same profile reference leaves this setting unchanged. Clearing the profile also
543+
// disables this setting. Requires a profile to be set on the pool.
541544
RefreshOnProfileUpdate param.Opt[bool] `json:"refresh_on_profile_update,omitzero"`
542545
// If provided, replaces the number of browsers to maintain in the pool. The
543546
// maximum size is determined by your organization's pooled sessions limit (the sum

0 commit comments

Comments
 (0)