11.6.2: Lag on player join

[TZ122]

Are you using MySQL?

Yes

Are you using a proxy?

No

"/version ChatControlRed" - plugin version

11.6.2

Optional: Error log

https://spark.lucko.me/tKSxSl2GzF

ZIP of "/chc debug"

When a player joins using the new chatcontrol there is a large lag spike.

Steps to reproduce

Install chc11.6.2, have a player join while running a spark report ticks over 150

[TZ122]

Adding as a note here: this happens when players leave as well. My TPS goes down to 0.9

[TZ122]

Updating here - I disabled join.rs and quit.rs from "where should messages apply" setting (i also had stop on first match if relevant). The lag has gone away. I have a huge handful of placeholder checks when the player joins. This was not an issue on previous versions of CHC. Is there a way to optimize this? I could have sworn there was an old setting to run this async.. I may be dreaming. Thanks for any help.. Here is an example of what I have disabled temporarily in join.rs: https://pastebin.com/qUwwRKmJ

[devpedrobarbosa]

Hey @TZ122, thanks for reaching out.

The lag spike shown in the Spark report points to PlaceholderAPI as the source of the expensive call.

At the moment, we’re simply requesting placeholder values through their public API.

I’ll bring this up with @kangarko on Tuesday to get confirmation and discuss possible options.

Fow now, I'll have to close this issue. Feel free to reach back.

[TZ122]

Thanks I'll look out here for a comment in Tuesday

[TZ122]

Hello @devpedrobarbosa were you able to discuss this scenario?

Thanks

[devpedrobarbosa]

@TZ122

Actually I was, sorry.

As I already mentioned, this is coming from a custom placeholder expansion. Nothing at all that we can do.

You should check your expansions and try to diagnose which one is laggy.