Support non-square aspect ratios #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old flag `constrain` which always locked the aspect ratio to 1:1. New flag `aspectRatio` allows setting any aspect ratio. Also fixed that `selectAll` did not trigger `crop.data`.
Contributor
Author
|
Fixes #1 |
Contributor
Author
There was a problem hiding this comment.
Forgot to mention that there's another fix in this PR. Previously dragging the selection upwards toward the left or top edges and releasing the mouse would not trigger crop.finish because either coords.x or coords.y where 0. Not sure how the logic works here with JS but looking to see if they are all numbers instead fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old flag
constrainwhich always locked the aspect ratio to 1:1. New flagaspectRatioallows setting any aspect ratio. Also fixed thatselectAlldid not triggercrop.data.