Update error codes to remove application specific ones

These were either not errors at all (just range definitions) or
were in the application specific range, so not appropriate to keep
in a more general library.

Author: Seelengrab

src/core.jl

@@ -16,6 +16,28 @@ struct JSONRPCError <: Exception
     data::Any
 end
 
+"""
+    SERVER_ERROR_END
+
+The end of the range of server-reserved errors.
+
+These are JSON-RPC server errors that are free for the taking
+for JSON-RPC server implementations. Applications making use of
+this library should NOT define new errors in this range.
+"""
+const SERVER_ERROR_END       = -32000
+
+"""
+    SERVER_ERROR_START
+
+The start of the range of server-reserved errors.
+
+These are JSON-RPC server errors that are free for the taking
+for JSON-RPC server implementations. Applications making use of
+this library should NOT define new errors in this range.
+"""
+const SERVER_ERROR_START     = -32099
+
 """
     PARSE_ERROR
 
@@ -52,10 +74,6 @@ Internal JSON-RPC error.
 """
 const INTERNAL_ERROR = -32603
 
-# these are the reserved endpoints of JSON-RPC error codes
-const SERVER_ERROR_END       = -32000
-const SERVER_ERROR_START     = -32099
-
 """
    RPCErrorStrings
 
@@ -70,13 +88,8 @@ const RPCErrorStrings = Base.IdDict(
     INVALID_PARAMS => "InvalidParams",
     INTERNAL_ERROR => "InternalError",
     [ i => "ServerError" for i in SERVER_ERROR_START:SERVER_ERROR_END]...,
-    # TODO: these should be removed - they are in the application/implementation specific range
-    -32000 => "serverErrorEnd",
-    -32099 => "serverErrorStart",
     -32002 => "ServerNotInitialized",
     -32001 => "UnknownErrorCode",
-    -32800 => "RequestCancelled",
-	-32801 => "ContentModified"
 )
 
 function Base.showerror(io::IO, ex::JSONRPCError)

test/test_core.jl

@@ -4,11 +4,7 @@
     @test sprint(showerror, JSONRPC.JSONRPCError(-32601, "FOO", "BAR")) == "MethodNotFound: FOO (BAR)"
     @test sprint(showerror, JSONRPC.JSONRPCError(-32602, "FOO", "BAR")) == "InvalidParams: FOO (BAR)"
     @test sprint(showerror, JSONRPC.JSONRPCError(-32603, "FOO", "BAR")) == "InternalError: FOO (BAR)"
-    @test sprint(showerror, JSONRPC.JSONRPCError(-32099, "FOO", "BAR")) == "serverErrorStart: FOO (BAR)"
-    @test sprint(showerror, JSONRPC.JSONRPCError(-32000, "FOO", "BAR")) == "serverErrorEnd: FOO (BAR)"
     @test sprint(showerror, JSONRPC.JSONRPCError(-32002, "FOO", "BAR")) == "ServerNotInitialized: FOO (BAR)"
     @test sprint(showerror, JSONRPC.JSONRPCError(-32001, "FOO", "BAR")) == "UnknownErrorCode: FOO (BAR)"
-    @test sprint(showerror, JSONRPC.JSONRPCError(-32800, "FOO", "BAR")) == "RequestCancelled: FOO (BAR)"
-    @test sprint(showerror, JSONRPC.JSONRPCError(-32801, "FOO", "BAR")) == "ContentModified: FOO (BAR)"
     @test sprint(showerror, JSONRPC.JSONRPCError(1, "FOO", "BAR")) == "Unknown: FOO (BAR)"
 end