Add timeout to wait for document dimensions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I also noticed that there were problems when attempting to determine the height of the component while the keyboard is being dismissed as the dimensions are gradually increasing during the animation. I have amended the patch to wait until it has a pair of width/height values which match each other. |
2BAB
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I have managed to stop of SignaturePad from loading before the document has had time to set it's dimensions. Basically it polls every 100ms and waits for by default up 2 seconds, this can be configured in props.
This is a better fix then specifying explicit dimensions, it also does not interfere with that existing behaviour.
kevinstumpf#18