Skip to content

Commit fe342b2

Browse files
committed
ci(render): add -failfast2 to plantuml invocation
Without it, a render error writes the error text into the SVG and exits zero, so CI goes green while committing a broken diagram. Caught this after overview.svg was silently replaced by a one-line error file.
1 parent fd15201 commit fe342b2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/render-diagrams.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ jobs:
3939
"https://github.com/plantuml/plantuml/releases/download/v${PLANTUML_VERSION}/plantuml-${PLANTUML_VERSION}.jar"
4040
java -jar plantuml.jar -version
4141
42-
- name: Render SVG
42+
- name: Render diagrams
4343
run: |
4444
find . -name '*.puml' -not -path './.git/*' -print0 \
45-
| xargs -0 -r java -jar plantuml.jar -tsvg -tpng -nometadata
45+
| xargs -0 -r java -jar plantuml.jar -tsvg -tpng -nometadata -failfast2
4646
4747
- name: Commit rendered diagrams
4848
uses: stefanzweifel/git-auto-commit-action@v5

0 commit comments

Comments
 (0)