Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Commit bb266b9

Browse files
committed
PuppetJob -> WingJob
1 parent ada3bdb commit bb266b9

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

docs/proposals/puppet-wing-dry-run.rst

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Verify puppet will make sensible and expected changes to the cluster when runnin
3939

4040
$ tarmak cluster puppet-plan
4141

42-
which complements ``cluster puppet-plan`` verifying Terraform changes.
42+
which complements ``cluster plan`` verifying Terraform changes.
4343

4444
Changes
4545
=======
@@ -82,18 +82,18 @@ field for each type of source. For example, something like this in ``types.go``:
8282
}
8383
8484
85-
``PuppetJob``
85+
``WingJob``
8686
*************
8787

8888
A resource representing the application of a ``PuppetManifest`` on an instance:
8989

9090
.. code-block:: yaml
9191
92-
kind: PuppetJob
92+
kind: WingJob
9393
metadata:
9494
name: example-job
9595
spec:
96-
manifestRef:
96+
puppetManifestRef:
9797
name: example-manifest
9898
operation: "dry-run"
9999
instanceID: 1234
@@ -104,10 +104,17 @@ A resource representing the application of a ``PuppetManifest`` on an instance:
104104
This references a pre-existing ``PuppetManifest``, and performs the specified
105105
action on an instance.
106106

107+
If, in the future, we support other configuration management tools (ansible,
108+
chef, etc), these would be represented by separate fields.
109+
110+
Performing updates to puppet manifests will leave ``WingJob`` and
111+
``PuppetManifest`` resources hanging around. To prevent this, wing should only
112+
keep the last 15 (or some other number) WingJobs for each instance.
113+
107114
Changes to existing API objects
108115
-------------------------------
109116

110-
``InstanceSpec`` will have a ``manifestRef`` field also linking to a ``PuppetManifest`` resource.
117+
``InstanceSpec`` will have a ``puppetManifestRef`` field also linking to a ``PuppetManifest`` resource.
111118
This will be the manifest applied to the instance.
112119

113120
Changes to tarmak CLI
@@ -120,9 +127,9 @@ The planned workflow is to run::
120127

121128
$ tarmak cluster puppet-plan
122129

123-
which creates ``PuppetJob`` resources for either a subset of instances of each
130+
which creates ``WingJob`` resources for either a subset of instances of each
124131
type in the current cluster, or all instances. This blocks until
125-
``PuppetJob.Status.ExitCode`` for each created job is populated.
132+
``WingJob.Status.ExitCode`` for each created job is populated.
126133

127134
It would be nice to filter and only display results based on the exit code of puppet, but it seems the exit code is always ``0`` when ``--noop`` is enabled::
128135

@@ -134,7 +141,4 @@ Notable items
134141
Concerns
135142
--------
136143

137-
- Performing updates to puppet manifests will leave ``PuppetJob`` and
138-
``PuppetManifest`` resources hanging around. Should there be an automated clean
139-
up process for stale items?
140-
- We need to think about how to handle ``PuppetJob`` resources timing out in the case of an instance failure during a plan.
144+
- We need to think about how to handle ``WingJob`` resources timing out in the case of an instance failure during a plan.

0 commit comments

Comments
 (0)