Fix tag ID lookup for AI-generated questions

- Store tag ID in option data attribute when created
- Add getSelectedTagId() helper to find tag ID reliably
- Handle "tag already exists" error by selecting existing tag
- Add tag to allTags array when created so lookup works

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: jsb2092

questionbank/static/js/app.js

@@ -2984,17 +2984,41 @@
                 if (tagSelect.value === '__new__') {
                     const newTagName = prompt('Enter new tag name:');
                     if (newTagName && newTagName.trim()) {
+                        const trimmedName = newTagName.trim();
+
+                        // Check if tag already exists in dropdown
+                        const existingOpt = Array.from(tagSelect.options).find(o => o.textContent === trimmedName);
+                        if (existingOpt) {
+                            tagSelect.value = existingOpt.value;
+                            return;
+                        }
+
                         try {
-                            const res = await api('tags/', 'POST', { name: newTagName.trim() });
-                            // Add the new tag to the dropdown and select it
+                            const res = await api('tags/', 'POST', { name: trimmedName });
+                            // Add the new tag to the dropdown with ID as data attribute
                             const opt = document.createElement('option');
-                            opt.value = res.name;
-                            opt.textContent = res.name;
+                            opt.value = trimmedName;
+                            opt.textContent = trimmedName;
+                            opt.dataset.tagId = res.id;  // Store the ID
                             tagSelect.insertBefore(opt, tagSelect.lastChild);
-                            tagSelect.value = res.name;
-                            // Refresh allTags
-                            await loadTags();
+                            tagSelect.value = trimmedName;
+                            // Add to allTags so lookup works
+                            allTags.push({ id: res.id, name: res.name });
                         } catch (e) {
+                            // If tag already exists, try to find and select it
+                            if (e.message && e.message.includes('already exists')) {
+                                await loadTags();  // Refresh to get the existing tag
+                                const existingTag = allTags.find(t => t.name === trimmedName);
+                                if (existingTag) {
+                                    const opt = document.createElement('option');
+                                    opt.value = trimmedName;
+                                    opt.textContent = trimmedName;
+                                    opt.dataset.tagId = existingTag.id;
+                                    tagSelect.insertBefore(opt, tagSelect.lastChild);
+                                    tagSelect.value = trimmedName;
+                                    return;
+                                }
+                            }
                             alert('Failed to create tag: ' + e.message);
                             tagSelect.value = '';
                         }
@@ -3005,6 +3029,23 @@
             };
         }
 
+        // Get the tag ID from the selected option (either from data attribute or allTags lookup)
+        function getSelectedTagId() {
+            const tagSelect = document.getElementById('ai-tag');
+            const tagName = tagSelect.value;
+            if (!tagName || tagName === '__new__') return null;
+
+            // First check if the option has a stored tagId
+            const selectedOption = tagSelect.options[tagSelect.selectedIndex];
+            if (selectedOption && selectedOption.dataset.tagId) {
+                return parseInt(selectedOption.dataset.tagId);
+            }
+
+            // Fall back to looking up in allTags
+            const tag = allTags.find(t => t.name === tagName);
+            return tag ? tag.id : null;
+        }
+
         // AI Generation - File Drop Handlers
         function handleDragOver(e) {
             e.preventDefault();
@@ -3166,9 +3207,9 @@
                     };
 
                     if (tagName && tagName !== '__new__') {
-                        const tag = allTags.find(t => t.name === tagName);
-                        console.log('[AddAll] Looking for tag:', tagName, 'Found:', tag);
-                        if (tag) payload.tag_ids = [tag.id];
+                        const tagId = getSelectedTagId();
+                        console.log('[AddAll] Tag:', tagName, 'ID:', tagId);
+                        if (tagId) payload.tag_ids = [tagId];
                     }
 
                     await api('questions/', 'POST', payload);
@@ -3209,9 +3250,9 @@
                     };
 
                     // If tag selected, find its ID
-                    if (tagName) {
-                        const tag = allTags.find(t => t.name === tagName);
-                        if (tag) payload.tag_ids = [tag.id];
+                    if (tagName && tagName !== '__new__') {
+                        const tagId = getSelectedTagId();
+                        if (tagId) payload.tag_ids = [tagId];
                     }
 
                     await api('questions/', 'POST', payload);