Skip to content

NNTP Provider Quota does not work correctly #758

Description

@actuallyevan

I'm not very familiar with Go or the Altmount codebase so I'm not gonna go into too much detail, but after setting a Quota for my providers, I noticed the Quota was reported as "Resetsresetting.." on the dashboard:

Image

In an attempt to see whether this was just a visual bug, I did some AI driven debugging and determined that it is probably not just a visual bug.

There seems to be bugs with:

  • displaying the Quota in the dashboard
  • using "Reset Quota" button
  • the actual amount of data used in the Quota being properly stored in the database (improperly persisting through container restart)

Some relevant files would be:
https://github.com/javi11/altmount/blob/main/internal/pool/manager.go
https://github.com/javi11/altmount/blob/main/frontend/src/components/system/ProviderStatusTable.tsx

I'm hesistant to be too specific as I didn't do a very thorough confirmation of these details, but I can provide more information if needed.

For instance, I think the || !ps.QuotaExceeded check in the below code might prevent the limits from being reset automatically for providers which have not reached their Quota:

	for _, ps := range m.pool.Stats().Providers {
		if ps.QuotaBytes == 0 || !ps.QuotaExceeded {
			continue
		}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions