Strike-through doesn't render for linkified URLs

[kbilleter]

Description

When using the strike-through markup (~~) around a URL the tildas render literally

To Reproduce

A simple file will demonstrate it

a test
https://github.com

(

~~a test~~
~~https://github.com~~

)

Context

My operating system is: MacOS Sequoia

Running viv --version outputs:

vivify-server v0.12.0

I installed Vivify in the following way (e.g. name of the package manager, self-compiled or development mode): self-compiled

In the following I specify if I use any custom configuration, and if so provide it in its entirety including any additional files referenced there (e.g. CSS or JavaScript): no customisation

[jannis-baum]

Hey! Thanks for opening this. This is very interesting because it's something that is natively handled by the markdown parser we use, markdown-it, specifically by its linkify option.

After checking the URI spec I saw that the tilde is actually an unreserved character, meaning you could technically have a valid URL end in two tildes. That said, you could argue that markdown-it is doing it correctly and GitHub is the one doing it "wrong". Maybe I also missed something, I didn't investigate super deeply, just did a quick phone search on the train.

Not sure what to do with this – I don't think it would make sense to try and change this (e.g. with an option to go off-spec) on Vivify's side, if anything that would have to happen on markdown-it. I checked very briefly and couldn't find anything about it there.
@tuurep @Tweekism feel free to add your opinions/findings as well :)

[kbilleter]

Happy to use HTML too.

I noticed moving from a fork of markdown-preview.nvim (where it does strike-through linkified URLs) to Vivify. Maybe due to an earlier version of linkify-it?

[Tweekism]

According to the markdown "spec" so to speak, naked links should be wrapped in angle brackets. So if you are looking for a work around, this works and is nicer than using HTML.

~~a test~~
~~<https://github.com>~~

source: https://www.markdownguide.org/basic-syntax/#urls-and-email-addresses

As for a real fix, since plain urls aren't technically supposed to be marked up, its a little difficult to authoritatively state what the correct behaviour should be. The linkify thing is kinda a hack really. Saying that, from a user perspective, if you are going to detect links, seems logical that you could strike through links.

I'm having a look at markdown-preview.nvim now to see what the specific difference is.

[jannis-baum]

Closing this because (1) implementation is not in Vivify and (2) technically the way markdown-it's linkify does it is technically closer to the spec. Feel free to reopen in case there's more to discuss or you disagree :)