Cursor sync offset/more centered (like Vim's `scrolloff`)

[tuurep]

From offtopic discussion

Me:

The way the cursor line is at the very bottom of the page feels pretty disorienting to me when opening

But what I'm getting to with this is that I wish the cursor sync could have a similar option to Vim's scrolloff, if you know what I mean

But of course it's more complicated because lines aren't a fixed size like in terminal

Jannis:

Yes definitely. I have also had this thought but haven't followed it to think about how to implement that, haha. We use JavaScript's scrollIntoView for the scrolling, we could look into that and see how much effort it would be to implement or if that's already a feature there anyways

EDIT maybe also this. Can't look into it in detail right now.

[jannis-baum]

This is probably a topic for main Vivify🙈

[tuurep]

Oh.. okay

E: transfer was surprisingly easy

[jannis-baum]

Fancy! I have never used this transfer feature before but seems like its perfect for us!

[jannis-baum]

@tuurep I think for this we'll need a way to pass config options to the client. Maybe you could adjust

Vivify/src/routes/viewer.ts

Lines 85 to 86 in 419eb5b

	window.VIV_PORT = "${config.port}";
	window.VIV_PATH = "${urlToPath(req.path)}";

to just add one property to window, e.g.

`window.VIV_INFO = {
    "port": "${config.port}",
    "path": "${urlToPath(req.path)}",
    "config": {
        // ...
    }
}`

so that we don't pollute it and end up with a million things on window.

[tuurep]

On most alternative projects I've tried for #224, the default is to scroll in a way that the page is centered at where the cursor is in Neovim, and I have to say that feels like a better option than what we currently have.

Also I had some idea in Signal a while back, I'll dig those messages up and quote them here:

Me:

yeah so the idea is related to this worst-case scenario with what youre viewing:

but if the 'position to scroll to' would instead be the last visible line in vim window:

would sorta match better to "what youre actually viewing in vim"

..but even in that image theres a problem: now the spot where the cursor is at isn't visible in browser :/

Jannis reply:

aaah nice! i like the ideas. with that we could actually maybe even take the top line, bottom line and cursor line of the vim window and do something in vivify to find the "optimal" position of the viewer that best matches the vim window

That's as far as we explored that but it's possible there could be a solid idea here...