[RELEASE] iText 7 Core - 7.1.6

https://github.com/itext/itext7-dotnet/releases/tag/7.1.6

* release/7.1.6:
  [RELEASE] 7.1.6-SNAPSHOT -> 7.1.6
  Throw exception if PdfReader instance is attempted to be reused between PdfDocument instances
  Add missing copyright headers
  Do not mark annotations as modified when simply reading them in append mode
  Fix Names PdfObject not being marked as modified in append mode
  Catch failed newline glyph retrieval
  Update port-hash
  Update port-hash
  Update hashCode and equals methods of some line-processing related classes.
  Fix minor issue in XMPDateTimeImpl constructor
  Suppress XML doc related warnings
  Remove NETStandard.Library dependency as implicit.
  Add searching differences in type 3 font forming
  Add missing copyright headers
  Change the way of checking transparency on the page
  SVG: Use actual closePath operator in PDF syntax
  Update port-hash
  Add test on advanced stroke properties
  Refactor PdfType0Font#getToUnicode logic
  Update port-hash
  Implement image masks filtering
  Update cmp files for Hebrew acroform test
  Fix incorrect glyph appearance for hebrew glyphs (fillFieldWithHebrewCase2 test).
  Added tests for DEVSIX-2069
  Increase rebuilding xref table log message severity up to ERROR
  Improve documentation and naming for signature integrity, authenticity and document coverage checks
  Add tests for ISA and SWA attacks
  Remove font-asian duplicates from io-module
  Add getter for color prop of the form field
  Wrap old content when flattening fields
  Update port-hash
  Set color on font when drawing a TextField with MaxLen
  fix issue in pdfTokenizer, if minus char '-' is found after '.' in a real number then omitt everything after the '.' char. following the adobe reader rule DEVSIX-2674
  Unify the criteria which are used to consider a font to be bold.
  Add info about pdfHTML and pdfSweep to README
  Extract PdfPage coping excluded keys
  Update the table's fixed-layout algorithm in case of a negative width remained.
  SVG paths: Support smooth curves
  Remove attributes checks of certificate extensions in CertificateVerification class and improve list of known standard extensions
  Handle noninvertible transformation matricies. Add some tests.
  Update port-hash
  Update port-hash
  Inherit MaxLen property for form fields
  Add some new direction log messages.
  Complete PdfAcroForm#getAcroForm() javadoc
  Extract color and fontSize property when creating a form field; normalize button field font size
  Downgrade exception to worning to allow for a work around implementation of vertical text
  Add "core" and "itextcore" to tags for iText7 Core nuget package
  Simplify PdfFormCopyTest#largeFilePerformanceTest
  Add control on field. Check null value Add test case
  Avoid use of MethodHandler
  add svg and styled-xml-parser to README DEVSIX-2717
  Fix OCSPVerifier responder certificate verification
  Improve contribution guidelines
  Update PdfAFormFieldTest
  Allow unknown annotation type in PdfAnnot:makeAnnot
  Fix documentation of PdfTextExtractor
  Add more tests
  Test for text element background opacity
  Add text element background opacity
  Remove unused imports and add @category for tests
  Throw up warning instead of error for larger MediaBox entries
  Add missing copyright headers
  Avoid splitting at an hyphen used to denote a negative value
  Embed OCSP response for all certificates in the chain in PdfSigner#signDetached
  Support creating OCSP responses for different certificates using TestOcspClient
  Remove unparsable CP1252 characters for TypeScript
  Optimize check for words boundary in LocationTextExtractionStrategy
  Fix possible issues with invalid OpenType anchor data
  Add javadoc for PdfDocument#setTagged()
  Avoid fonts creation when fetching the needed data on registerDirectory()
  Don't fail on initial whitespace in path operator
  Fix issue with incorrect ref parsing
  Delete unnecessary maven-javadoc plugin param, delete obsolete profile for javadoc
  Fix Javadoc errors, eliminate a number of Javadoc warnings
  Fix problem with excess xref entries in copying PdfPage as XObject
  Reorder methods in AbstractSvgNodeRenderer for CC
  Support transparency in SVG, both opacity and rgba
  Add missing copyright headers
  SVG: Support for Elliptical paths
  Add missing copyright headers
  Support for Text-anchor attribute
  Implement TSpan support
  Upgrade Surefire and Failsafe
  Make default pages handling for open-close scenario more tolerable for invalid /Contents entry
  Do not add default font to document, just make it indirect
  SVG: Support (x y)+ parameters in MoveTo path operator
  Modify the page's resources if necessary.
  Refactor and improve drawing of text field's appearances. Add some tests.
  Ignore the Comb flag if the field doesn't have a MaxLen entry.
  Add test for setLineThrough() behavior with setTextRise()
  Add a few tests for deferred signing
  Do not throw an exception if a form field doesn't have /MaxLen and Comb flag is set.
  Cover the case of updating LTV verification data of PDF in which DSS does not contain VRI entry
  Introduce barcode constructors which take font as a parameter. Update javadocs a bit.  Add new barcode + pdfa tests.
  Extract background and border color property when creating a form field
  add missing doc
  Update rotation documentation
  Update port-hash after release
  [RELEASE] 7.1.5-SNAPSHOT -> 7.1.6-SNAPSHOT
  Remove pdftest dependency from package configs
  Add the reset functionality to FontProvider.

Author: iText-CI

CONTRIBUTING.md

@@ -70,83 +70,29 @@ Before you submit your pull request consider the following guidelines:
 * Please sign the [iText Contributor License Agreement (iCLA)](#cla) before sending pull
   requests for any change of more than 20 significant lines of code (we're not counting curly braces and other syntactical sugar).
   We cannot accept code without this agreement.
-* Clone **iText 7 Community** to your local machine.
-
-     ```shell
-     git clone [email protected]:itext/itext7.git
-     cd itext7
-     git fetch origin
-     git checkout -b develop origin/develop
-     ```
-
-* Make your changes in a new git branch based off the develop branch:
-
-     ```shell
-     git checkout -b my-fix-branch develop
-     ```
-
-* Create your patch, **including appropriate test cases**.
+* Fork the iText repository on GitHub.
+* Clone your iText fork to your local machine.
+* Make your changes, **including appropriate test cases**.
 * Follow our [Coding Rules](#rules).
-* Run the full **iText 7 Community** test suite and ensure that all tests pass.
 * Commit your changes using a descriptive commit message that follows our
   [commit message conventions](#commit-message-format).
-
-     ```shell
-     git commit -a
-     ```
-  Note: the optional commit `-a` command line option will automatically `add` and `rm` edited files.
-
 * Now would be a good time to fix up your commits (if you want or need to) with `git rebase --interactive`.
 * Build your changes locally to ensure all the tests pass.
-* Push your branch to your GitHub account:
-
-    ```shell
-    git remote add my-remote [email protected]:my-remote/itext7.git
-    git push my-remote my-fix-branch
-    ```
-
-* In GitHub, send a pull request to `itext7:develop`.
+* Push your changes to your GitHub account.
+* Create a pull request in GitHub.
+"Head fork" should be your repository, and the "base fork" should be the iText7 official repository.
 * If we suggest changes then:
   * Make the required updates.
-  * Re-run the **iText 7 Community** test suite to ensure tests are still passing.
-  * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
-
-    ```shell
-    git fetch origin
-    git rebase develop -i
-    git push my-remote my-fix-branch -f
-    ```
+  * Fix up your commits if needed, with an interactive rebase.
+  * Re-run the tests and make sure that they are still passing.
+  * Force push to your GitHub repository. This will update your Pull Request.
 
 That's it! Thank you for your contribution!
 
 #### After your pull request is merged
 
-After your pull request is merged, you can safely delete your branch and pull the changes
-from the main (upstream) repository:
-
-* Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:
-
-    ```shell
-    git push my-remote --delete my-fix-branch
-    ```
-
-* Check out the develop branch:
-
-    ```shell
-    git checkout develop -f
-    ```
-
-* Delete the local branch:
-
-    ```shell
-    git branch -D my-fix-branch
-    ```
-
-* Update your develop with the latest upstream version:
-
-    ```shell
-    git pull --ff upstream develop
-    ```
+After your pull request is merged, you can safely delete your fork and pull the changes
+from the main (upstream) repository.
 
 
 ## <a name="rules">Coding Rules</a>

README.md

@@ -1,4 +1,4 @@
-**[iText 7 Community][itext]** for .NET consists of several dlls.
+**[iText 7 Community for .NET][itext]** (former iTextSharp) consists of several dlls.
 
 The **iText 7 Core/Community** release contains:
 
@@ -12,6 +12,8 @@ The **iText 7 Core/Community** release contains:
 - ```hyph.dll```: use this if you want text to be hyphenated
 - ```font-asian.dll```: use this is you need CJK functionality (Chinese / Japanese / Korean)
 - ```sign.dll```: use this if you need support for digital signatures
+- ```styled-xml-parser.dll```: use this if you need support for SVG or html2pdf
+- ```svg.dll```: SVG support
 
 The **iText 7 Community** source code is hosted on [Github][github], where you can also [download the latest releases][latest].
 
@@ -21,11 +23,10 @@ The **iText 7 Community** source code is hosted on [Github][github], where you c
 
 You can also [build iText 7 Community from source][building].
 
-We also have a Java tool that can help you debug PDFs:
-
-- ```itext-rups-x.y.z.jar```
-
-RUPS is also hosted on [Github][github-rups].
+We also provide opensource add-ons and tools to complement the core functionality:
+- [pdfHTML][pdfhtml] — allows you to easily convert HTML to PDF or iText objects
+- [pdfSweep][pdfsweep] — a highly efficient PDF tool to merge, split and redact data
+- [RUPS][rups] — a Java tool that can help you debug PDFs
 
 If you have an idea on how to improve **iText 7 Community** and you want to submit code,
 please read our [Contribution Guidelines][contributing].
@@ -50,10 +51,12 @@ Contact [sales] for more info.
 [agpl]: LICENSE.md
 [building]: BUILDING.md
 [contributing]: CONTRIBUTING.md
-[itext]: http://itextpdf.com/
+[itext]: https://itextpdf.com/
 [github]: https://github.com/itext/itext7-dotnet
-[github-rups]: http://github.com/itext/rups
 [latest]: https://github.com/itext/itext7-dotnet/releases/latest
 [nuget]: https://www.nuget.org/packages/itext7
-[sales]: http://itextpdf.com/sales
+[sales]: https://itextpdf.com/sales
 [gratis]: https://en.wikipedia.org/wiki/Gratis_versus_libre
+[rups]: https://github.com/itext/rups
+[pdfhtml]: https://github.com/itext/i7n-pdfhtml
+[pdfsweep]: https://github.com/itext/i7n-pdfsweep

itext.tests/itext.barcodes.tests/Properties/AssemblyInfo.cs

@@ -14,9 +14,9 @@
 
 [assembly: Guid("d015a3aa-613c-45d9-b908-7d47c4b613af")]
 
-[assembly: AssemblyVersion("7.1.5.0")]
-[assembly: AssemblyFileVersion("7.1.5.0")]
-[assembly: AssemblyInformationalVersion("7.1.5")]
+[assembly: AssemblyVersion("7.1.6.0")]
+[assembly: AssemblyFileVersion("7.1.6.0")]
+[assembly: AssemblyInformationalVersion("7.1.6")]
 
 #if !NETSTANDARD1_6
 [assembly: NUnit.Framework.Timeout(300000)]

itext.tests/itext.barcodes.tests/itext.barcodes.tests.csproj

@@ -24,6 +24,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>CS1591;CS1570;CS1572;CS1573;CS1574;CS1580;CS1584;CS1658</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -32,6 +33,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>CS1591;CS1570;CS1572;CS1573;CS1574;CS1580;CS1584;CS1658</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="nunit.framework, Version=3.7.1.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">

itext.tests/itext.barcodes.tests/itext.barcodes.tests.netstandard.csproj

@@ -25,6 +25,9 @@
     <AssemblyName>itext.barcodes.tests</AssemblyName>
     <RootNamespace />
   </PropertyGroup>
+  <PropertyGroup>
+    <NoWarn>1701;1702;1591;1570;1572;1573;1574;1580;1584;1658</NoWarn>
+  </PropertyGroup>
   <ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
     <Reference Include="System" />
     <Reference Include="System.Core" />

itext.tests/itext.forms.tests/Properties/AssemblyInfo.cs

@@ -14,9 +14,9 @@
 
 [assembly: Guid("6fe2f714-6b3e-4b20-8c70-28bfce084ed2")]
 
-[assembly: AssemblyVersion("7.1.5.0")]
-[assembly: AssemblyFileVersion("7.1.5.0")]
-[assembly: AssemblyInformationalVersion("7.1.5")]
+[assembly: AssemblyVersion("7.1.6.0")]
+[assembly: AssemblyFileVersion("7.1.6.0")]
+[assembly: AssemblyInformationalVersion("7.1.6")]
 
 #if !NETSTANDARD1_6
 [assembly: NUnit.Framework.Timeout(300000)]

itext.tests/itext.forms.tests/itext.forms.tests.csproj

@@ -23,6 +23,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>CS1591;CS1570;CS1572;CS1573;CS1574;CS1580;CS1584;CS1658</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -31,6 +32,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>CS1591;CS1570;CS1572;CS1573;CS1574;CS1580;CS1584;CS1658</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="nunit.framework, Version=3.7.1.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">

itext.tests/itext.forms.tests/itext.forms.tests.netstandard.csproj

@@ -25,6 +25,9 @@
     <AssemblyName>itext.forms.tests</AssemblyName>
     <RootNamespace />
   </PropertyGroup>
+  <PropertyGroup>
+    <NoWarn>1701;1702;1591;1570;1572;1573;1574;1580;1584;1658</NoWarn>
+  </PropertyGroup>
   <ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
     <Reference Include="System" />
     <Reference Include="System.Core" />

itext.tests/itext.forms.tests/itext/forms/FlatteningWithNullKidElementTest.cs

@@ -0,0 +1,79 @@
+/*
+This file is part of the iText (R) project.
+Copyright (c) 1998-2019 iText Group NV
+Authors: iText Software.
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU Affero General Public License version 3
+as published by the Free Software Foundation with the addition of the
+following permission added to Section 15 as permitted in Section 7(a):
+FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+ITEXT GROUP. ITEXT GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+OF THIRD PARTY RIGHTS
+
+This program is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+or FITNESS FOR A PARTICULAR PURPOSE.
+See the GNU Affero General Public License for more details.
+You should have received a copy of the GNU Affero General Public License
+along with this program; if not, see http://www.gnu.org/licenses or write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA, 02110-1301 USA, or download the license from the following URL:
+http://itextpdf.com/terms-of-use/
+
+The interactive user interfaces in modified source and object code versions
+of this program must display Appropriate Legal Notices, as required under
+Section 5 of the GNU Affero General Public License.
+
+In accordance with Section 7(b) of the GNU Affero General Public License,
+a covered work must retain the producer line in every PDF that is created
+or manipulated using iText.
+
+You can be released from the requirements of the license by purchasing
+a commercial license. Buying such a license is mandatory as soon as you
+develop commercial activities involving the iText software without
+disclosing the source code of your own applications.
+These activities include: offering paid services to customers as an ASP,
+serving PDFs on the fly in a web application, shipping iText with a closed
+source product.
+
+For more information, please contact iText Software Corp. at this
+address: [email protected]
+*/
+using System;
+using iText.Kernel.Pdf;
+using iText.Test;
+
+namespace iText.Forms {
+    public class FlatteningWithNullKidElementTest : ExtendedITextTest {
+        public static readonly String sourceFolder = iText.Test.TestUtil.GetParentProjectDirectory(NUnit.Framework.TestContext
+            .CurrentContext.TestDirectory) + "/resources/itext/forms/FlatteningWithNullKidElementTest/";
+
+        public static readonly String destinationFolder = NUnit.Framework.TestContext.CurrentContext.TestDirectory
+             + "/test/itext/forms/FlatteningWithNullKidElementTest/";
+
+        [NUnit.Framework.OneTimeSetUp]
+        public static void BeforeClass() {
+            CreateDestinationFolder(destinationFolder);
+        }
+
+        /// <exception cref="System.IO.IOException"/>
+        /// <exception cref="System.Exception"/>
+        [NUnit.Framework.Test]
+        public virtual void FormFlatteningTestWithNullKidElement() {
+            String filename = "Form_NullKidElement";
+            String src = sourceFolder + filename + ".pdf";
+            String temp = destinationFolder + "temp.pdf";
+            PdfDocument doc = new PdfDocument(new PdfReader(src), new PdfWriter(temp));
+            bool fail = false;
+            try {
+                PdfAcroForm.GetAcroForm(doc, true).FlattenFields();
+                doc.Close();
+            }
+            catch (Exception) {
+                fail = true;
+            }
+            NUnit.Framework.Assert.IsFalse(fail);
+        }
+    }
+}

itext.tests/itext.forms.tests/itext/forms/PdfFormCopyTest.cs

@@ -114,24 +114,19 @@ public virtual void CopyFieldsTest03() {
 
         /// <exception cref="System.IO.IOException"/>
         /// <exception cref="System.Exception"/>
-#if !NETSTANDARD1_6
-        [NUnit.Framework.Timeout(100000)]
-#endif
         [NUnit.Framework.Test]
-        public virtual void LargeFilePerformanceTest() {
+        public virtual void LargeFileTest() {
             String srcFilename1 = sourceFolder + "frontpage.pdf";
             String srcFilename2 = sourceFolder + "largeFile.pdf";
             String filename = destinationFolder + "copyLargeFile.pdf";
-            long timeStart = System.DateTime.Now.Ticks;
             PdfDocument doc1 = new PdfDocument(new PdfReader(srcFilename1));
             PdfDocument doc2 = new PdfDocument(new PdfReader(srcFilename2));
             PdfDocument pdfDoc = new PdfDocument(new PdfWriter(filename));
             pdfDoc.InitializeOutlines();
             PdfPageFormCopier formCopier = new PdfPageFormCopier();
             doc1.CopyPagesTo(1, doc1.GetNumberOfPages(), pdfDoc, formCopier);
-            doc2.CopyPagesTo(1, doc2.GetNumberOfPages(), pdfDoc, formCopier);
+            doc2.CopyPagesTo(1, 10, pdfDoc, formCopier);
             pdfDoc.Close();
-            System.Console.Out.WriteLine(((System.DateTime.Now.Ticks - timeStart) / 1000 / 1000));
             NUnit.Framework.Assert.IsNull(new CompareTool().CompareByContent(filename, sourceFolder + "cmp_copyLargeFile.pdf"
                 , destinationFolder, "diff_"));
         }