Skip to content

fix zh version top blank #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix zh version top blank #15824

merged 1 commit into from
Oct 24, 2024

Conversation

@Arhell
Copy link
Member

@Arhell Arhell commented Oct 23, 2024

resolve #15819

@Arhell Arhell requested a review from a team as a code owner October 23, 2024 21:18
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2024
@istio-testing istio-testing merged commit 7688cc7 into istio:master Oct 24, 2024
6 checks passed
@Arhell Arhell deleted the fix-zh branch October 24, 2024 07:53
craigbox
craigbox reviewed Oct 24, 2024
View reviewed changes
@wilsonwu
Copy link
Member

wilsonwu commented Oct 24, 2024 •
edited
Loading

Seems the problem still there? Hope the latest site is up to date:
image

I compared the css class of head section between ZH and EN page, but no problem found :(

@Arhell
Copy link
Member Author

Arhell commented Oct 24, 2024

Seems the problem still there? Hope the latest site is up to date: image

I compared the css class of head section between ZH and EN page, but no problem found :(

This is not css problem
In preview all good
https://deploy-preview-15824--preliminary-istio.netlify.app/latest/zh

@wilsonwu
Copy link
Member

wilsonwu commented Oct 24, 2024

Seems the problem still there? Hope the latest site is up to date: image
I compared the css class of head section between ZH and EN page, but no problem found :(

This is not css problem In preview all good https://deploy-preview-15824--preliminary-istio.netlify.app/latest/zh

Great, thanks so much, not sure when the prod site will be updated.

@Arhell
Copy link
Member Author

Arhell commented Oct 24, 2024

I think so, because I checked the new PR and the old ones, the problem disappeared

New
#15828
https://deploy-preview-15828--preliminary-istio.netlify.app/latest/zh

Old
#15772
https://deploy-preview-15772--istio.netlify.app/latest/zh/

@windsonsea windsonsea added the cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch label Oct 24, 2024
@istio-testing
Copy link
Contributor

istio-testing commented Oct 24, 2024

In response to a cherrypick label: new pull request created: #15830

@istio-testing istio-testing mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigbox craigbox craigbox left review comments

@windsonsea windsonsea windsonsea approved these changes

Assignees

No one assigned

Labels

cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The latest Chinese version of doc site with a top blank

5 participants

@Arhell @wilsonwu @istio-testing @craigbox @windsonsea