Skip to content

Conversation

@Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Oct 9, 2025

Closes #228
Closes #229

This was linked to issues Oct 13, 2025
@Alex6323 Alex6323 marked this pull request as ready for review October 13, 2025 06:50
@Alex6323 Alex6323 changed the title chore(examples): add TransactionBuilder upgrade example chore(examples): add TransactionBuilder publish and upgrade example Oct 14, 2025
Copy link
Contributor

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the bindings?

@Alex6323
Copy link
Contributor Author

Alex6323 commented Oct 16, 2025

What about the bindings?

I realized during the Rust example that it's probably better for the end-user to merge the publish steps and upgrade steps respectively internally in the builder. This is because one step implies the next. At least that's my current understand. Please correct me if I am wrong.

@DaughterOfMars DaughterOfMars marked this pull request as draft October 21, 2025 12:36
@Alex6323
Copy link
Contributor Author

I'm a bit late to the party, can you TL;DR if it would have been too annoying/repetitive to split the example in 2?

it would have been because in order to upgrade you need to make sure there's published package. So ... with 2 examples you have code duplication of publishing.

@Alex6323 Alex6323 merged commit 558bca5 into sdk-bindings Oct 28, 2025
14 checks passed
@Alex6323 Alex6323 deleted the chore/add-upgrade-example branch October 28, 2025 17:23
This was referenced Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tx builder: upgrade example Tx builder: publish example

5 participants