Commit abb9506
fix(checkbox, toggle): uniform helper text style for ionic theme (#30893)
Issue number: resolves #
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
Helper and Error text style it's not uniform between elements.
## What is the new behavior?
* Changed the typography for `.checkbox-bottom` and `.toggle-bottom` to
use `globals.$ion-body-sm-medium` for a more consistent appearance with
other components.
[[1]](diffhunk://#diff-796ffc72b6171910c25d5aad085bc245095c38f104d55e253e06282702205066L116-R116)
[[2]](diffhunk://#diff-ad6128c5d08f42a970eab3a8c7081eaad590bd4ebbcd19ec4e6110a6f7977040L59-R70)
* Updated the color of `.input-bottom .helper-text` and `.input-bottom
.counter` to use `globals.$ion-text-subtlest` instead of
`globals.$ion-primitives-neutral-800`, and `.input-bottom .error-text`
to use `globals.$ion-text-danger`.
* Standardized `.textarea-bottom .error-text` to use
`globals.$ion-text-danger` and reordered the CSS for clarity, while
`.textarea-bottom .helper-text` and `.textarea-bottom .counter` use
`globals.$ion-text-subtlest`.
* Updated `.toggle-bottom .error-text` to use `globals.$ion-text-danger`
and `.toggle-bottom .helper-text` to use `globals.$ion-text-subtlest`
for improved semantic clarity and consistency.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
---------
Co-authored-by: ionitron <hi@ionicframework.com>1 parent 6c74618 commit abb9506
52 files changed
Lines changed: 13 additions & 13 deletions
File tree
- core/src/components
- checkbox
- test/bottom-content/checkbox.e2e.ts-snapshots
- input
- textarea
- toggle
- test/bottom-content/toggle.e2e.ts-snapshots
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
0 commit comments