Skip to content

Commit ee8edac

Browse files
authored
Merge pull request #92 from intergral/well_knowns
fix(service name): fix missing support for wellknown labels in tag va…
2 parents 9c5f1e4 + 0b91bfc commit ee8edac

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!-- main START -->
22
# main (unreleased)
33
- **[BUGFIX]**: fix missing data in frame response [#89](https://github.com/intergral/deep/pull/89) [@Umaaz](https://github.com/Umaaz)
4+
- **[BUGFIX]**: fix missing support for well known labels [#92](https://github.com/intergral/deep/pull/92) [@Umaaz](https://github.com/Umaaz)
45
<!-- main START -->
56

67
<!-- main START -->

pkg/deepdb/encoding/vparquet/block_search_tags.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,13 @@ func searchTagValues(ctx context.Context, tag deepql.Attribute, cb common.TagCal
214214
return nil
215215
}
216216

217+
if column, ok := wellKnownColumnLookups[tag.Name]; ok {
218+
err := searchSpecialTagValues(ctx, column.columnPath, pf, cb)
219+
if err != nil {
220+
return fmt.Errorf("unexpected error searching special tags: %w", err)
221+
}
222+
}
223+
217224
// Finally also search generic key/values
218225
err := searchStandardTagValues(ctx, tag, pf, cb)
219226
if err != nil {

0 commit comments

Comments
 (0)