diff --git a/src/xccl/ProcessGroupXCCL.cpp b/src/xccl/ProcessGroupXCCL.cpp index e2bf50079..01d10c79f 100644 --- a/src/xccl/ProcessGroupXCCL.cpp +++ b/src/xccl/ProcessGroupXCCL.cpp @@ -369,15 +369,15 @@ ProcessGroupXCCL::ProcessGroupXCCL( int size, c10::intrusive_ptr options) : Backend(rank, size), - store_(store), - options_(std::move(options)), + store_(std::move(store)), xcclCommCounter_(0), - local_id_(process_group_id++) { + local_id_(process_group_id++), + options_(std::move(options)) { + this->setGroupUid(options_->group_name); logPrefix_ = createLogPrefix(); blockingWait_ = getCvarBool(TORCH_XCCL_BLOCKING_WAIT, false); traceBufferSize_ = getCvarInt({"TORCH_FR_BUFFER_SIZE"}, 2000); - this->setGroupUid(options_->group_name); // In PGNCCL, the pg ranks are recorded on comm setup in each op, but we just // do it here. const auto XcclVersion = getXcclVersion(); diff --git a/src/xccl/ProcessGroupXCCL.hpp b/src/xccl/ProcessGroupXCCL.hpp index 632e05cf2..276cd0cec 100644 --- a/src/xccl/ProcessGroupXCCL.hpp +++ b/src/xccl/ProcessGroupXCCL.hpp @@ -128,8 +128,6 @@ class TORCH_API ProcessGroupXCCL : public Backend { return c10::make_intrusive(is_high_priority_stream); } bool is_high_priority_stream; - std::vector global_ranks_in_group; - std::string group_name; }; ProcessGroupXCCL(