Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Commit 42bd9cf

Browse files
committed
Merge pull request #45 from krocard/xml_coverage_create_element
Use minidom factory methods in xml coverage generator
2 parents de462ef + 794fea6 commit 42bd9cf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tools/coverage/coverage.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,14 @@ def dump(self, withCoverage=False, withNbUse=True):
204204
str(dumpedDescription) for dumpedDescription in
205205
self._dumpDescription(withCoverage, withNbUse))
206206

207-
def exportToXML(self, domElement=None):
207+
def exportToXML(self, document, domElement=None):
208208
if domElement == None:
209-
domElement = xml.dom.minidom.Element(self.tag)
209+
domElement = document.createElement(self.tag)
210210

211211
self._XMLaddAttributes(domElement)
212212

213213
for child in self.children :
214-
domElement.appendChild(child.exportToXML())
214+
domElement.appendChild(child.exportToXML(document))
215215

216216
return domElement
217217

@@ -877,10 +877,10 @@ def __init__(self, name, dom):
877877
def exportToXML(self):
878878
"""Export tree to an xml document"""
879879
impl = xml.dom.minidom.getDOMImplementation()
880-
newdoc = impl.createDocument(namespaceURI=None, qualifiedName=self.tag, doctype=None)
881-
super().exportToXML(newdoc.documentElement)
880+
document = impl.createDocument(namespaceURI=None, qualifiedName=self.tag, doctype=None)
881+
super().exportToXML(document, document.documentElement)
882882

883-
return newdoc
883+
return document
884884

885885
# ============================
886886
# Command line argument parser

0 commit comments

Comments
 (0)