Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Commit 36423a4

Browse files
dawagnerpafonso
authored andcommitted
Fix SystemClass duplicate 'Name' attribute in xml export
When refactoring Element::toXml, we forgot to make the necessary adaptation in SystemClass::toXml. The latter does not need to set the Name attribute anymore because this is taken care of by the base toXml method. SystemClass::toXml now only calls the base and can therefore be completely removed. Change-Id: Ibd12feaac2c101dcc22e8716e332cb02f03ba99a Tracked-On: https://jira01.devtools.intel.com/browse/IMINAN-19676 Signed-off-by: David Wagner <[email protected]>
1 parent 3eeafab commit 36423a4

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

parameter/SystemClass.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,3 @@ bool CSystemClass::init(string& strError)
314314
{
315315
return base::init(strError);
316316
}
317-
318-
// From IXmlSource
319-
void CSystemClass::toXml(CXmlElement& xmlElement, CXmlSerializingContext& serializingContext) const
320-
{
321-
// Set the name of system class
322-
xmlElement.setNameAttribute(getName());
323-
324-
base::toXml(xmlElement, serializingContext);
325-
}

parameter/SystemClass.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ class CSystemClass : public CConfigurableElement
7575
virtual bool init(std::string& strError);
7676
virtual std::string getKind() const;
7777

78-
// From IXmlSource
79-
virtual void toXml(CXmlElement& xmlElement, CXmlSerializingContext& serializingContext) const;
80-
8178
private:
8279
CSystemClass(const CSystemClass&);
8380
CSystemClass& operator=(const CSystemClass&);

0 commit comments

Comments
 (0)