Skip to content

fix: commit signoff is enforced by the organization #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 10, 2025
Merged

fix: commit signoff is enforced by the organization #2763

merged 9 commits into from
Nov 10, 2025

Conversation

@steveteuber
Copy link
Contributor

@steveteuber steveteuber commented Sep 30, 2025 •
edited
Loading

Recreate the pull request #2222 to resolve issue #2077.

Before the change?

  • There is a bug in the GitHub API 2022-11-28 version that causes a 422 error when updating a repository within an organization that has "Require sign off on web-based commits" enabled.

After the change?

  • On a repository update, we check if the organization has "Require sign off on web-based commits" enabled.
    If it's enabled, we do not send the web_commit_signoff_required field in the update request to avoid the 422 error.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • No

@steveteuber steveteuber mentioned this pull request Oct 1, 2025
Closed
@steveteuber
Copy link
Contributor Author

steveteuber commented Oct 9, 2025

@nickfloyd can you review this pull request? This would be great 😉

@brunom-lexipol
Copy link

brunom-lexipol commented Nov 6, 2025

Bump! 🙏

@nickfloyd nickfloyd moved this from Backlog to In Review in Terraform Provider Nov 10, 2025
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Nov 10, 2025
nickfloyd
nickfloyd approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nickfloyd nickfloyd merged commit 59e2bd5 into integrations:main Nov 10, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Nov 10, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Terraform Provider Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees

No one assigned

Labels

Type: Bug Something isn't working as documented

Projects

Terraform Provider
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steveteuber @brunom-lexipol @nickfloyd @bzarboni1