Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 2, 2025

Description

A slight improvement of the Contest Ballot document cddl definition, with minor fixes/updates of document definitions.

Related Issue(s)

Part of #634

Description of Changes

  • Changed document_ref to uint for the Contest Ballot payload CDDL definition.
  • Added missing ref metadata field definition for the Contest Ballot.
  • Updated definition of the collaborators and document_refs types.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy requested a review from stevenj December 2, 2025 05:57
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Dec 2, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/contest-ballot-payload-update

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Test Report | ${\color{lightgreen}Pass: 585/585}$ | ${\color{red}Fail: 0/585}$ |

@Mr-Leshiy Mr-Leshiy added the requires architect review Requires at least 1 architect to sign off on PR before merge. label Dec 2, 2025
nathanbogale
nathanbogale previously approved these changes Dec 2, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Dec 3, 2025
@Mr-Leshiy Mr-Leshiy requested a review from stevenj December 3, 2025 14:24
@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) December 3, 2025 14:48
@Mr-Leshiy Mr-Leshiy merged commit 0b38ad4 into main Dec 4, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/contest-ballot-payload-update branch December 4, 2025 01:18
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Catalyst Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires architect review Requires at least 1 architect to sign off on PR before merge. review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants