Skip to content

Commit 319fbec

Browse files
dreisptdreispt
committed
[IMP] Update pre-commit to current OCA standards, dob compatible
1 parent 24bd079 commit 319fbec

3 files changed

Lines changed: 250 additions & 25 deletions

File tree

‎.pre-commit-config.yaml‎

Lines changed: 95 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,66 @@
1+
exclude: |
2+
(?x)
3+
# NOT INSTALLABLE ADDONS
4+
# END NOT INSTALLABLE ADDONS
5+
# Files and folders generated by bots, to avoid loops
6+
^setup/|/static/description/index\.html$|
7+
# We don't want to mess with tool-generated files
8+
.svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
9+
# Maybe reactivate this when all README files include prettier ignore tags?
10+
^README\.md$|
11+
# Library files can have extraneous formatting (even minimized)
12+
/static/(src/)?lib/|
13+
# Repos using Sphinx to generate docs don't need prettying
14+
^docs/_templates/.*\.html$|
15+
# You don't usually want a bot to modify your legal texts
16+
(LICENSE.*|COPYING.*)|
17+
# Exclude external addons
18+
odoo/src/ext_addons/|
19+
# Exclude container config file, especially the generated ones
20+
^odoo/*.*
21+
default_language_version:
22+
python: python3
23+
node: "14.18.0"
124
repos:
25+
- repo: local
26+
hooks:
27+
# These files are most likely copier diff rejection junks; if found,
28+
# review them manually, fix the problem (if needed) and remove them
29+
- id: forbidden-files
30+
name: forbidden files
31+
entry: found forbidden files; remove them
32+
language: fail
33+
files: "\\.rej$"
34+
- repo: https://github.com/myint/autoflake
35+
rev: v1.4
36+
hooks:
37+
- id: autoflake
38+
args:
39+
- --expand-star-imports
40+
- --ignore-init-module-imports
41+
- --in-place
42+
- --remove-all-unused-imports
43+
- --remove-duplicate-keys
44+
- --remove-unused-variables
245
- repo: https://github.com/psf/black
3-
rev: 20.8b1
46+
rev: 21.9b0
447
hooks:
548
- id: black
6-
749
- repo: https://github.com/pre-commit/mirrors-prettier
8-
rev: v2.1.2
50+
rev: v2.4.1
951
hooks:
1052
- id: prettier
11-
name: prettier + plugin-xml
53+
name: prettier (with plugin-xml)
1254
additional_dependencies:
13-
- "prettier@2.1.2"
14-
- "@prettier/plugin-xml@0.12.0"
55+
- "prettier@2.4.1"
56+
- "@prettier/plugin-xml@1.1.0"
1557
args:
1658
- --config=odoo/.prettierrc.yml
1759
- --plugin=@prettier/plugin-xml
1860
- --ignore-path=odoo/.prettierignore
19-
61+
files: \.(css|htm|html|js|json|jsx|less|md|scss|toml|ts|xml|yaml|yml)$
2062
- repo: https://github.com/pre-commit/mirrors-eslint
21-
rev: v7.8.1
63+
rev: v7.32.0
2264
hooks:
2365
- id: eslint
2466
verbose: true
@@ -27,31 +69,62 @@ repos:
2769
- --fix
2870
- --config=odoo/.eslintrc.yml
2971
- --ignore-path=odoo/.eslintignore
30-
31-
- repo: https://gitlab.com/pycqa/flake8
32-
rev: 3.8.2
72+
- repo: https://github.com/pre-commit/pre-commit-hooks
73+
rev: v4.0.1
3374
hooks:
34-
- id: flake8
35-
additional_dependencies: [flake8-bugbear]
36-
args:
37-
- --config=odoo/.flake8
38-
75+
- id: trailing-whitespace
76+
# exclude autogenerated files
77+
exclude: /README\.rst$|\.pot?$
78+
- id: end-of-file-fixer
79+
# exclude autogenerated files
80+
exclude: /README\.rst$|\.pot?$
81+
- id: debug-statements
82+
- id: fix-encoding-pragma
83+
args: ["--remove"]
84+
- id: check-case-conflict
85+
- id: check-docstring-first
86+
- id: check-executables-have-shebangs
87+
- id: check-merge-conflict
88+
# exclude files where underlines are not distinguishable from merge conflicts
89+
exclude: /README\.rst$|^docs/.*\.rst$
90+
- id: check-symlinks
91+
- id: check-xml
92+
- id: mixed-line-ending
93+
args: ["--fix=lf"]
94+
- repo: https://github.com/asottile/pyupgrade
95+
rev: v2.29.0
96+
hooks:
97+
- id: pyupgrade
98+
args: ["--keep-percent-format"]
3999
- repo: https://github.com/PyCQA/isort
40-
rev: 5.5.1
100+
rev: 5.9.3
41101
hooks:
42102
- id: isort
43-
name: isort
103+
name: isort except __init__.py
104+
exclude: /__init__\.py$
44105
args:
45106
- --settings=odoo/
46-
107+
- repo: https://gitlab.com/PyCQA/flake8
108+
rev: 3.9.2
109+
hooks:
110+
- id: flake8
111+
name: flake8
112+
additional_dependencies: ["flake8-bugbear==21.9.2"]
113+
args:
114+
- --config=odoo/.flake8
47115
- repo: https://github.com/PyCQA/pylint
48-
rev: pylint-2.5.3
116+
rev: v2.11.1
49117
hooks:
50118
- id: pylint
51-
name: pylint
119+
name: pylint with optional checks
52120
args:
53121
- --rcfile=odoo/.pylintrc
54122
- --exit-zero
55123
verbose: true
56124
additional_dependencies: &pylint_deps
57-
- pylint-odoo==5.0.0
125+
- pylint-odoo==5.0.4
126+
- id: pylint
127+
name: pylint with mandatory checks
128+
args:
129+
- --rcfile=odoo/.pylintrc-mandatory
130+
additional_dependencies: *pylint_deps

‎odoo/.pylintrc‎

Lines changed: 60 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,22 @@ score=n
44

55
[ODOOLINT]
66
readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
7+
manifest_required_authors=Odoo Community Association (OCA)
78
manifest_required_keys=license
89
manifest_deprecated_keys=description,active
910
license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
11+
valid_odoo_versions=15.0
1012

1113
[MESSAGES CONTROL]
1214
disable=all
1315

16+
# This .pylintrc contains optional AND mandatory checks and is meant to be
17+
# loaded in an IDE to have it check everything, in the hope this will make
18+
# optional checks more visible to contributors who otherwise never look at a
19+
# green travis to see optional checks that failed.
20+
# .pylintrc-mandatory containing only mandatory checks is used the pre-commit
21+
# config as a blocking check.
22+
1423
enable=anomalous-backslash-in-string,
1524
api-one-deprecated,
1625
api-one-multi-together,
@@ -19,6 +28,7 @@ enable=anomalous-backslash-in-string,
1928
class-camelcase,
2029
dangerous-default-value,
2130
dangerous-view-replace-wo-priority,
31+
development-status-allowed,
2232
duplicate-id-csv,
2333
duplicate-key,
2434
duplicate-xml-fields,
@@ -35,8 +45,6 @@ enable=anomalous-backslash-in-string,
3545
method-inverse,
3646
method-required-super,
3747
method-search,
38-
missing-import-error,
39-
missing-manifest-dependency,
4048
openerp-exception-warning,
4149
pointless-statement,
4250
pointless-string-statement,
@@ -54,7 +62,56 @@ enable=anomalous-backslash-in-string,
5462
unreachable,
5563
use-vim-comment,
5664
wrong-tabs-instead-of-spaces,
57-
xml-syntax-error
65+
xml-syntax-error,
66+
attribute-string-redundant,
67+
character-not-valid-in-resource-link,
68+
consider-merging-classes-inherited,
69+
context-overridden,
70+
create-user-wo-reset-password,
71+
dangerous-filter-wo-user,
72+
dangerous-qweb-replace-wo-priority,
73+
deprecated-data-xml-node,
74+
deprecated-openerp-xml-node,
75+
duplicate-po-message-definition,
76+
except-pass,
77+
file-not-used,
78+
invalid-commit,
79+
manifest-maintainers-list,
80+
missing-newline-extrafiles,
81+
missing-readme,
82+
missing-return,
83+
odoo-addons-relative-import,
84+
old-api7-method-defined,
85+
po-msgstr-variables,
86+
po-syntax-error,
87+
renamed-field-parameter,
88+
resource-not-exist,
89+
str-format-used,
90+
test-folder-imported,
91+
translation-contains-variable,
92+
translation-positional-used,
93+
unnecessary-utf8-coding-comment,
94+
website-manifest-key-not-valid-uri,
95+
xml-attribute-translatable,
96+
xml-deprecated-qweb-directive,
97+
xml-deprecated-tree-attribute,
98+
# messages that do not cause the lint step to fail
99+
consider-merging-classes-inherited,
100+
create-user-wo-reset-password,
101+
dangerous-filter-wo-user,
102+
deprecated-module,
103+
file-not-used,
104+
invalid-commit,
105+
missing-manifest-dependency,
106+
missing-newline-extrafiles,
107+
missing-readme,
108+
no-utf8-coding-comment,
109+
odoo-addons-relative-import,
110+
old-api7-method-defined,
111+
redefined-builtin,
112+
too-complex,
113+
unnecessary-utf8-coding-comment
114+
58115

59116
[REPORTS]
60117
msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}

‎odoo/.pylintrc-mandatory‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
[MASTER]
2+
load-plugins=pylint_odoo
3+
score=n
4+
5+
[ODOOLINT]
6+
readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
7+
manifest_required_authors=Odoo Community Association (OCA)
8+
manifest_required_keys=license
9+
manifest_deprecated_keys=description,active
10+
license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
11+
valid_odoo_versions=15.0
12+
13+
[MESSAGES CONTROL]
14+
disable=all
15+
16+
enable=anomalous-backslash-in-string,
17+
api-one-deprecated,
18+
api-one-multi-together,
19+
assignment-from-none,
20+
attribute-deprecated,
21+
class-camelcase,
22+
dangerous-default-value,
23+
dangerous-view-replace-wo-priority,
24+
development-status-allowed,
25+
duplicate-id-csv,
26+
duplicate-key,
27+
duplicate-xml-fields,
28+
duplicate-xml-record-id,
29+
eval-referenced,
30+
eval-used,
31+
incoherent-interpreter-exec-perm,
32+
license-allowed,
33+
manifest-author-string,
34+
manifest-deprecated-key,
35+
manifest-required-key,
36+
manifest-version-format,
37+
method-compute,
38+
method-inverse,
39+
method-required-super,
40+
method-search,
41+
openerp-exception-warning,
42+
pointless-statement,
43+
pointless-string-statement,
44+
print-used,
45+
redundant-keyword-arg,
46+
redundant-modulename-xml,
47+
reimported,
48+
relative-import,
49+
return-in-init,
50+
rst-syntax-error,
51+
sql-injection,
52+
too-few-format-args,
53+
translation-field,
54+
translation-required,
55+
unreachable,
56+
use-vim-comment,
57+
wrong-tabs-instead-of-spaces,
58+
xml-syntax-error,
59+
attribute-string-redundant,
60+
character-not-valid-in-resource-link,
61+
consider-merging-classes-inherited,
62+
context-overridden,
63+
create-user-wo-reset-password,
64+
dangerous-filter-wo-user,
65+
dangerous-qweb-replace-wo-priority,
66+
deprecated-data-xml-node,
67+
deprecated-openerp-xml-node,
68+
duplicate-po-message-definition,
69+
except-pass,
70+
file-not-used,
71+
invalid-commit,
72+
manifest-maintainers-list,
73+
missing-newline-extrafiles,
74+
missing-readme,
75+
missing-return,
76+
odoo-addons-relative-import,
77+
old-api7-method-defined,
78+
po-msgstr-variables,
79+
po-syntax-error,
80+
renamed-field-parameter,
81+
resource-not-exist,
82+
str-format-used,
83+
test-folder-imported,
84+
translation-contains-variable,
85+
translation-positional-used,
86+
unnecessary-utf8-coding-comment,
87+
website-manifest-key-not-valid-uri,
88+
xml-attribute-translatable,
89+
xml-deprecated-qweb-directive,
90+
xml-deprecated-tree-attribute
91+
92+
[REPORTS]
93+
msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}
94+
output-format=colorized
95+
reports=no

0 commit comments

Comments
 (0)