wip: db maintenance cleanup and tests

Author: prestwich

crates/db/Cargo.toml

@@ -29,3 +29,8 @@ tracing.workspace = true
 futures-util = "0.3.31"
 tokio.workspace = true
 auto_impl = "1.3.0"
+
+[dev-dependencies]
+serde_json.workspace = true
+reth-db = { workspace = true, features = ["test-utils"] }
+reth-exex-test-utils.workspace = true

crates/db/src/convert.rs

@@ -1,7 +1,8 @@
 //! Type conversion traits and implementations for converting between Reth, Alloy, and Signet types.
 //!
-//! This module provides a set of conversion traits that enable seamless interoperability
-//! between different type systems used in the Ethereum ecosystem:
+//! This module provides a set of conversion traits that enable seamless
+//! interoperability between different type systems used in the Ethereum
+//! ecosystem:
 //!
 //! - **Reth types**: Core primitives from the Reth Ethereum client
 //! - **Alloy types**: Modern Ethereum types from the Alloy framework

crates/db/src/provider.rs

@@ -104,31 +104,6 @@ where
             .map_err(Into::into)
     }
 
-    /// Increase the balance of an account.
-    fn mint_eth(&self, address: Address, amount: U256) -> ProviderResult<Account> {
-        let mut account = self.basic_account(&address)?.unwrap_or_default();
-        account.balance = account.balance.saturating_add(amount);
-        self.tx_ref().put::<PlainAccountState>(address, account)?;
-        trace!(%address, balance = %account.balance, "minting ETH");
-        Ok(account)
-    }
-
-    /// Decrease the balance of an account.
-    fn burn_eth(&self, address: Address, amount: U256) -> ProviderResult<Account> {
-        let mut account = self.basic_account(&address)?.unwrap_or_default();
-        if amount > account.balance {
-            warn!(
-                balance = %account.balance,
-                amount = %amount,
-                "burning more than balance"
-            );
-        }
-        account.balance = account.balance.saturating_sub(amount);
-        self.tx_ref().put::<PlainAccountState>(address, account)?;
-        trace!(%address, balance = %account.balance, "burning ETH");
-        Ok(account)
-    }
-
     fn insert_signet_header(
         &self,
         header: Zenith::BlockHeader,

crates/db/src/traits.rs

@@ -31,12 +31,6 @@ pub trait RuWriter {
     /// Get the latest journal hash from the DB.
     fn latest_journal_hash(&self) -> ProviderResult<B256>;
 
-    /// Increase the balance of an account.
-    fn mint_eth(&self, address: Address, amount: U256) -> ProviderResult<Account>;
-
-    /// Decrease the balance of an account.
-    fn burn_eth(&self, address: Address, amount: U256) -> ProviderResult<Account>;
-
     /// Store a zenith header in the DB
     fn insert_signet_header(
         &self,

crates/db/tests/common/mod.rs

@@ -0,0 +1,33 @@
+use alloy::genesis::Genesis;
+use reth::{
+    chainspec::ChainSpec,
+    providers::{ProviderFactory, providers::StaticFileProvider},
+};
+use reth_db::test_utils::{create_test_rw_db, create_test_static_files_dir};
+use reth_exex_test_utils::TmpDB as TmpDb;
+use signet_node_types::SignetNodeTypes;
+use std::sync::{Arc, OnceLock};
+
+static GENESIS_JSON: &str = include_str!("../../../../tests/artifacts/local.genesis.json");
+
+static SPEC: OnceLock<Arc<ChainSpec>> = OnceLock::new();
+
+/// Returns a chain spec for tests.
+pub fn chain_spec() -> Arc<ChainSpec> {
+    SPEC.get_or_init(|| {
+        let genesis: Genesis = serde_json::from_str(GENESIS_JSON).expect("valid genesis json");
+        Arc::new(genesis.into())
+    })
+    .clone()
+}
+
+/// Create a provider factory with a chain spec
+pub fn create_test_provider_factory() -> ProviderFactory<SignetNodeTypes<TmpDb>> {
+    let (static_dir, _) = create_test_static_files_dir();
+    let db = create_test_rw_db();
+    ProviderFactory::new(
+        db,
+        chain_spec(),
+        StaticFileProvider::read_write(static_dir.keep()).expect("static file provider"),
+    )
+}

crates/db/tests/db.rs

@@ -0,0 +1,13 @@
+#[path = "./common/mod.rs"]
+mod test_common;
+
+use signet_db::RuWriter;
+
+#[test]
+fn test_ru_writer() {
+    let factory = test_common::create_test_provider_factory();
+
+    let writer = factory.provider_rw().unwrap();
+
+    dbg!(writer.last_block_number().unwrap());
+}