@@ -151,12 +151,16 @@ where
151151 // in `reth/crates/storage/provider/src/providers/database/provider.rs`
152152 // duration metrics have been removed
153153 //
154- // Last reviewed at tag v1.5 .1
154+ // Last reviewed at tag v1.8 .1
155155 let block_number = block. number ( ) ;
156+
157+ // SIGNET-SPECIFIC
158+ // Put journal hash into the DB
156159 if let Some ( header) = header {
157160 self . insert_signet_header ( header, block_number) ?;
158161 }
159162
163+ // SIGNET-SPECIFIC
160164 // Put journal hash into the DB
161165 self . tx_ref ( ) . put :: < crate :: JournalHashes > ( block_number, journal_hash) ?;
162166
@@ -226,7 +230,7 @@ where
226230 // duration metrics have been removed, and the implementation has been
227231 // modified to work with a single signet block.
228232 //
229- // last reviewed at tag v1.5 .1
233+ // last reviewed at tag v1.8 .1
230234
231235 let sf = self . static_file_provider ( ) ;
232236
@@ -333,7 +337,7 @@ where
333337 let mut items = Vec :: new ( ) ;
334338 trace ! ( target: "signet_db_lifecycle" , "taking zenith headers" ) ;
335339 let mut cursor_write = self . tx_ref ( ) . cursor_write :: < ZenithHeaders > ( ) ?;
336- let mut walker = cursor_write. walk_range ( target..) ?;
340+ let mut walker = cursor_write. walk_range ( target + 1 ..) ?;
337341 while let Some ( ( k, DbZenithHeader ( e) ) ) = walker. next ( ) . transpose ( ) ? {
338342 walker. delete_current ( ) ?;
339343 items. push ( ( k, e) )
@@ -348,7 +352,7 @@ where
348352 target : BlockNumber ,
349353 _remove_from : StorageLocation ,
350354 ) -> ProviderResult < ( ) > {
351- self . remove :: < ZenithHeaders > ( target..) ?;
355+ self . remove :: < ZenithHeaders > ( target + 1 ..) ?;
352356 Ok ( ( ) )
353357 }
354358
@@ -371,7 +375,7 @@ where
371375 target : BlockNumber ,
372376 remove_from : StorageLocation ,
373377 ) -> ProviderResult < Vec < ( BlockNumber , DbSignetEvent ) > > {
374- let range = target..= ( 1 + self . last_block_number ( ) ?) ;
378+ let range = target + 1 ..= self . last_block_number ( ) ?;
375379 let items = self . get_signet_events ( range) ?;
376380 self . remove_signet_events_above ( target, remove_from) ?;
377381 Ok ( items)
@@ -386,7 +390,7 @@ where
386390 target : BlockNumber ,
387391 _remove_from : StorageLocation ,
388392 ) -> ProviderResult < ( ) > {
389- self . remove :: < SignetEvents > ( target..) ?;
393+ self . remove :: < SignetEvents > ( target + 1 ..) ?;
390394 Ok ( ( ) )
391395 }
392396
@@ -415,7 +419,7 @@ where
415419 // in `reth/crates/storage/provider/src/providers/database/provider.rs`
416420 // duration metrics have been removed
417421 //
418- // last reviewed at tag v1.5 .1
422+ // last reviewed at tag v1.8 .1
419423
420424 let BlockResult { sealed_block : block, execution_outcome, .. } = block_result;
421425
@@ -467,13 +471,13 @@ where
467471 // `BlockExecutionWriter::take_block_and_execution_above`
468472 // in `reth/crates/storage/provider/src/providers/database/provider.rs`
469473 //
470- // last reviewed at tag v1.5 .1
474+ // last reviewed at tag v1.8 .1
471475
472- let range = target..=self . last_block_number ( ) ?;
476+ let range = target + 1 ..=self . last_block_number ( ) ?;
473477
474478 // This block is copied from `unwind_trie_state_range`
475479 //
476- // last reviewed at tag v1.5 .1
480+ // last reviewed at tag v1.8 .1
477481 {
478482 let changed_accounts = self
479483 . tx_ref ( )
@@ -537,21 +541,21 @@ where
537541 #[ instrument( skip( self ) ) ]
538542 fn ru_remove_blocks_and_execution_above (
539543 & self ,
540- target : BlockNumber ,
544+ block : BlockNumber ,
541545 remove_from : StorageLocation ,
542546 ) -> ProviderResult < ( ) > {
543547 // Implementation largely copied from
544548 // `BlockExecutionWriter::remove_block_and_execution_above`
545549 // in `reth/crates/storage/provider/src/providers/database/provider.rs`
546550 // duration metrics have been removed
547551 //
548- // last reviewed at tag v1.5 .1
552+ // last reviewed at tag v1.8 .1
549553
550554 // This block is copied from `unwind_trie_state_range`
551555 //
552- // last reviewed at tag v1.5 .1
556+ // last reviewed at tag v1.8 .1
553557 {
554- let range = target ..=self . last_block_number ( ) ?;
558+ let range = block + 1 ..=self . last_block_number ( ) ?;
555559 let changed_accounts = self
556560 . tx_ref ( )
557561 . cursor_read :: < tables:: AccountChangeSets > ( ) ?
@@ -572,14 +576,14 @@ where
572576 self . unwind_storage_history_indices ( changed_storages. iter ( ) . copied ( ) ) ?;
573577 }
574578
575- self . remove_state_above ( target , remove_from) ?;
576- self . remove_blocks_above ( target , remove_from) ?;
579+ self . remove_state_above ( block , remove_from) ?;
580+ self . remove_blocks_above ( block , remove_from) ?;
577581
578582 // Signet specific:
579- self . remove_extraction_results_above ( target , remove_from) ?;
583+ self . remove_extraction_results_above ( block , remove_from) ?;
580584
581585 // Update pipeline stages
582- self . update_pipeline_stages ( target , true ) ?;
586+ self . update_pipeline_stages ( block , true ) ?;
583587
584588 Ok ( ( ) )
585589 }
@@ -594,7 +598,7 @@ where
594598 // `StateWriter::write_state` for `DatabaseProvider`
595599 // in `reth/crates/storage/provider/src/providers/database/provider.rs`
596600 //
597- // Last reviewed at tag v1.5 .1
601+ // Last reviewed at tag v1.8 .1
598602 let first_block = execution_outcome. first_block ( ) ;
599603 let block_count = execution_outcome. len ( ) as u64 ;
600604 let last_block = execution_outcome. last_block ( ) ;
0 commit comments