Skip to content

Commit 098d26a

Browse files
committed
refactor: introduce a chill type alias
1 parent 69d42d5 commit 098d26a

File tree

5 files changed

+31
-29
lines changed

5 files changed

+31
-29
lines changed

crates/db/src/aliases.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
use reth::providers::DatabaseProviderRW;
2+
use signet_node_types::SignetNodeTypes;
3+
4+
/// A Convenience alias for a [`DatabaseProviderRW`] using [`SignetNodeTypes`].
5+
pub type SignetDbRw<Db> = DatabaseProviderRW<Db, SignetNodeTypes<Db>>;

crates/db/src/journal/mod.rs

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,38 +3,35 @@
33
mod r#trait;
44
pub use r#trait::JournalDb;
55

6+
use crate::SignetDbRw;
67
use futures_util::{Stream, StreamExt};
7-
use reth::providers::{DatabaseProviderRW, ProviderResult};
8-
use signet_node_types::{NodeTypesDbTrait, SignetNodeTypes};
8+
use reth::providers::ProviderResult;
9+
use signet_node_types::NodeTypesDbTrait;
910
use std::sync::Arc;
1011
use tokio::task::JoinHandle;
1112
use trevm::journal::BlockUpdate;
1213

1314
/// A task that ingests journals into a reth database.
1415
#[derive(Debug)]
1516
pub struct JournalIngestor<Db: NodeTypesDbTrait> {
16-
db: Arc<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>,
17+
db: Arc<SignetDbRw<Db>>,
1718
}
1819

19-
impl<Db: NodeTypesDbTrait> From<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>
20-
for JournalIngestor<Db>
21-
{
22-
fn from(value: DatabaseProviderRW<Db, SignetNodeTypes<Db>>) -> Self {
20+
impl<Db: NodeTypesDbTrait> From<SignetDbRw<Db>> for JournalIngestor<Db> {
21+
fn from(value: SignetDbRw<Db>) -> Self {
2322
Self::new(value.into())
2423
}
2524
}
2625

27-
impl<Db: NodeTypesDbTrait> From<Arc<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>>
28-
for JournalIngestor<Db>
29-
{
30-
fn from(value: Arc<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>) -> Self {
26+
impl<Db: NodeTypesDbTrait> From<Arc<SignetDbRw<Db>>> for JournalIngestor<Db> {
27+
fn from(value: Arc<SignetDbRw<Db>>) -> Self {
3128
Self::new(value)
3229
}
3330
}
3431

3532
impl<Db: NodeTypesDbTrait> JournalIngestor<Db> {
3633
/// Create a new `JournalIngestor` with the given database provider.
37-
pub const fn new(db: Arc<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>) -> Self {
34+
pub const fn new(db: Arc<SignetDbRw<Db>>) -> Self {
3835
Self { db }
3936
}
4037

@@ -71,10 +68,7 @@ impl<Db: NodeTypesDbTrait> JournalIngestor<Db> {
7168
}
7269

7370
/// Ingest journals from a stream into a reth database.
74-
pub async fn ingest_journals<Db, S>(
75-
db: Arc<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>,
76-
stream: S,
77-
) -> ProviderResult<()>
71+
pub async fn ingest_journals<Db, S>(db: Arc<SignetDbRw<Db>>, stream: S) -> ProviderResult<()>
7872
where
7973
Db: NodeTypesDbTrait,
8074
S: Stream<Item = (alloy::consensus::Header, BlockUpdate<'static>)> + Send + Unpin + 'static,

crates/db/src/lib.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
#![deny(unused_must_use, rust_2018_idioms)]
1212
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
1313

14+
mod aliases;
15+
pub use aliases::SignetDbRw;
16+
1417
mod chain;
1518
pub use chain::{DbExtractionResults, RuChain};
1619

crates/db/src/provider.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use crate::{
2-
DataCompat, DbZenithHeader, RuChain, ZenithHeaders,
2+
DataCompat, DbZenithHeader, RuChain, SignetDbRw, ZenithHeaders,
33
tables::{DbSignetEvent, JournalHashes, SignetEvents},
44
traits::RuWriter,
55
};
@@ -11,9 +11,9 @@ use reth::{
1111
primitives::{Account, StaticFileSegment},
1212
providers::{
1313
AccountReader, BlockBodyIndicesProvider, BlockNumReader, BlockReader, BlockWriter, Chain,
14-
DBProvider, DatabaseProviderRW, HistoryWriter, OriginalValuesKnown, ProviderError,
15-
ProviderResult, StageCheckpointWriter, StateWriter, StaticFileProviderFactory,
16-
StaticFileWriter, StorageLocation,
14+
DBProvider, HistoryWriter, OriginalValuesKnown, ProviderError, ProviderResult,
15+
StageCheckpointWriter, StateWriter, StaticFileProviderFactory, StaticFileWriter,
16+
StorageLocation,
1717
},
1818
};
1919
use reth_db::{
@@ -25,7 +25,7 @@ use reth_db::{
2525
};
2626
use reth_prune_types::{MINIMUM_PRUNING_DISTANCE, PruneMode};
2727
use signet_evm::BlockResult;
28-
use signet_node_types::{NodeTypesDbTrait, SignetNodeTypes};
28+
use signet_node_types::NodeTypesDbTrait;
2929
use signet_types::primitives::RecoveredBlock;
3030
use signet_zenith::{
3131
Passage::{self, Enter, EnterToken},
@@ -35,7 +35,7 @@ use signet_zenith::{
3535
use std::ops::RangeInclusive;
3636
use tracing::{debug, instrument, trace, warn};
3737

38-
impl<Db> RuWriter for DatabaseProviderRW<Db, SignetNodeTypes<Db>>
38+
impl<Db> RuWriter for SignetDbRw<Db>
3939
where
4040
Db: NodeTypesDbTrait,
4141
{

crates/db/src/traits.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
use crate::{DbExtractionResults, DbSignetEvent, RuChain};
1+
use crate::{DbExtractionResults, DbSignetEvent, RuChain, SignetDbRw};
22
use alloy::primitives::{Address, B256, BlockNumber, U256};
33
use itertools::Itertools;
44
use reth::{
55
primitives::Account,
6-
providers::{DatabaseProviderRW, OriginalValuesKnown, ProviderResult, StorageLocation},
6+
providers::{OriginalValuesKnown, ProviderResult, StorageLocation},
77
};
88
use reth_db::models::StoredBlockBodyIndices;
99
use signet_evm::BlockResult;
10-
use signet_node_types::{NodeTypesDbTrait, SignetNodeTypes};
10+
use signet_node_types::NodeTypesDbTrait;
1111
use signet_types::primitives::RecoveredBlock;
1212
use signet_zenith::{Passage, Transactor, Zenith};
1313
use std::{collections::BTreeMap, ops::RangeInclusive};
@@ -293,7 +293,7 @@ pub trait RuWriter {
293293
}
294294

295295
/// Extend the [`DatabaseProviderRW`] with a guarded commit function.
296-
pub trait DbProviderExt<Db>: Into<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>
296+
pub trait DbProviderExt<Db>: Into<SignetDbRw<Db>>
297297
where
298298
Db: NodeTypesDbTrait,
299299
{
@@ -302,18 +302,18 @@ where
302302
/// transaction is rolled back.
303303
fn update(
304304
self,
305-
f: impl FnOnce(&mut DatabaseProviderRW<Db, SignetNodeTypes<Db>>) -> ProviderResult<()>,
305+
f: impl FnOnce(&mut SignetDbRw<Db>) -> ProviderResult<()>,
306306
) -> ProviderResult<()>;
307307
}
308308

309309
impl<T, Db> DbProviderExt<Db> for T
310310
where
311311
Db: NodeTypesDbTrait,
312-
T: Into<DatabaseProviderRW<Db, SignetNodeTypes<Db>>>,
312+
T: Into<SignetDbRw<Db>>,
313313
{
314314
fn update(
315315
self,
316-
f: impl FnOnce(&mut DatabaseProviderRW<Db, SignetNodeTypes<Db>>) -> ProviderResult<()>,
316+
f: impl FnOnce(&mut SignetDbRw<Db>) -> ProviderResult<()>,
317317
) -> ProviderResult<()> {
318318
let mut this = self.into();
319319
f(&mut this)?;

0 commit comments

Comments
 (0)