From 6af4959397232e61d6e29ed8ffe9c47c4fc2a9fe Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Sun, 19 Apr 2026 15:02:42 -0500 Subject: [PATCH 1/4] Update baseline --- .basedpyright/baseline.json | 272 +++++++++++++++++++++++++++++------- 1 file changed, 224 insertions(+), 48 deletions(-) diff --git a/.basedpyright/baseline.json b/.basedpyright/baseline.json index e8dde3ecb..333292fcb 100644 --- a/.basedpyright/baseline.json +++ b/.basedpyright/baseline.json @@ -1441,14 +1441,6 @@ } ], "./pytential/array_context.py": [ - { - "code": "reportUnknownVariableType", - "range": { - "startColumn": 4, - "endColumn": 22, - "lineCount": 1 - } - }, { "code": "reportUnusedImport", "range": { @@ -1863,6 +1855,14 @@ "lineCount": 1 } }, + { + "code": "reportArgumentType", + "range": { + "startColumn": 23, + "endColumn": 24, + "lineCount": 1 + } + }, { "code": "reportUnknownVariableType", "range": { @@ -3569,6 +3569,134 @@ "lineCount": 1 } }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 15, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 9, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 11, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 18, + "endColumn": 20, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 31, + "endColumn": 33, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 12, + "endColumn": 19, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 12, + "endColumn": 19, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 8, + "endColumn": 10, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 15, + "endColumn": 17, + "lineCount": 1 + } + }, + { + "code": "reportAny", + "range": { + "startColumn": 18, + "endColumn": 20, + "lineCount": 1 + } + }, { "code": "reportAny", "range": { @@ -3577,6 +3705,14 @@ "lineCount": 1 } }, + { + "code": "reportAny", + "range": { + "startColumn": 30, + "endColumn": 35, + "lineCount": 1 + } + }, { "code": "reportAny", "range": { @@ -3584,6 +3720,14 @@ "endColumn": 20, "lineCount": 1 } + }, + { + "code": "reportAny", + "range": { + "startColumn": 30, + "endColumn": 40, + "lineCount": 1 + } } ], "./pytential/qbx/__init__.py": [ @@ -11567,14 +11711,6 @@ "lineCount": 1 } }, - { - "code": "reportUnknownVariableType", - "range": { - "startColumn": 44, - "endColumn": 62, - "lineCount": 1 - } - }, { "code": "reportIncompatibleMethodOverride", "range": { @@ -17373,22 +17509,6 @@ "lineCount": 1 } }, - { - "code": "reportArgumentType", - "range": { - "startColumn": 24, - "endColumn": 41, - "lineCount": 1 - } - }, - { - "code": "reportUnknownArgumentType", - "range": { - "startColumn": 43, - "endColumn": 62, - "lineCount": 1 - } - }, { "code": "reportUnknownParameterType", "range": { @@ -17927,14 +18047,6 @@ "lineCount": 1 } }, - { - "code": "reportUnknownVariableType", - "range": { - "startColumn": 58, - "endColumn": 76, - "lineCount": 1 - } - }, { "code": "reportImplicitOverride", "range": { @@ -22057,6 +22169,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownArgumentType", + "range": { + "startColumn": 48, + "endColumn": 68, + "lineCount": 1 + } + }, { "code": "reportUnknownArgumentType", "range": { @@ -22129,6 +22249,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownArgumentType", + "range": { + "startColumn": 48, + "endColumn": 68, + "lineCount": 1 + } + }, { "code": "reportUnknownArgumentType", "range": { @@ -22145,6 +22273,22 @@ "lineCount": 1 } }, + { + "code": "reportUnknownArgumentType", + "range": { + "startColumn": 41, + "endColumn": 61, + "lineCount": 1 + } + }, + { + "code": "reportUnknownVariableType", + "range": { + "startColumn": 12, + "endColumn": 16, + "lineCount": 1 + } + }, { "code": "reportUnknownMemberType", "range": { @@ -22153,6 +22297,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownVariableType", + "range": { + "startColumn": 12, + "endColumn": 22, + "lineCount": 1 + } + }, { "code": "reportUnknownMemberType", "range": { @@ -22161,6 +22313,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownVariableType", + "range": { + "startColumn": 12, + "endColumn": 36, + "lineCount": 1 + } + }, { "code": "reportUnknownMemberType", "range": { @@ -22185,6 +22345,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownArgumentType", + "range": { + "startColumn": 44, + "endColumn": 64, + "lineCount": 1 + } + }, { "code": "reportUnknownArgumentType", "range": { @@ -22593,6 +22761,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownVariableType", + "range": { + "startColumn": 8, + "endColumn": 40, + "lineCount": 1 + } + }, { "code": "reportUnknownMemberType", "range": { @@ -22625,6 +22801,14 @@ "lineCount": 1 } }, + { + "code": "reportUnknownArgumentType", + "range": { + "startColumn": 58, + "endColumn": 78, + "lineCount": 1 + } + }, { "code": "reportUnknownArgumentType", "range": { @@ -27015,14 +27199,6 @@ "lineCount": 1 } }, - { - "code": "reportPossiblyUnboundVariable", - "range": { - "startColumn": 8, - "endColumn": 20, - "lineCount": 1 - } - }, { "code": "reportUnknownArgumentType", "range": { From 04cde09c929e10d3e72534aefaf93afea9d54442 Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Sun, 19 Apr 2026 15:03:45 -0500 Subject: [PATCH 2/4] Git ignore .venv --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index daf719e6f..331e1bb2a 100644 --- a/.gitignore +++ b/.gitignore @@ -23,6 +23,7 @@ examples/*.pdf *.vts .cache +.venv tags From 06a199ed7b5c8a339a3e1a8ad5db4ec09984b00f Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Sun, 19 Apr 2026 15:03:54 -0500 Subject: [PATCH 3/4] Bpr ignore .venv --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 4cde04131..56dd562e0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -173,6 +173,7 @@ ignore = [ "experiments", "pytential/symbolic/old_diffop_primitives.py", "pytential/symbolic/pde/maxwell/generalized_debye.py", + ".venv", ] [[tool.basedpyright.executionEnvironments]] From 4c11fac0eb2e526eaab044213d04b5aed610526c Mon Sep 17 00:00:00 2001 From: Andreas Kloeckner Date: Sun, 19 Apr 2026 16:01:45 -0500 Subject: [PATCH 4/4] Add a very bogus pyright ignore --- pytential/unregularized.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pytential/unregularized.py b/pytential/unregularized.py index a57bb00f6..b4a71f7be 100644 --- a/pytential/unregularized.py +++ b/pytential/unregularized.py @@ -296,7 +296,8 @@ def exec_compute_potential_insn_fmm(self, actx: PyOpenCLArrayContext, for o in insn.outputs: target_index = target_name_to_index[o.target_name] - target_slice = slice(*geo_data.target_info().target_discr_starts[ + # FIXME: very bogus pyright ignore + target_slice = slice(*geo_data.target_info().target_discr_starts[ # pyright: ignore[reportUnusedVariable] target_index:target_index+2]) target_discr = targets[target_index]