Skip to content

Commit ab239d8

Browse files
committed
Rename transformations to less long 'transform'
1 parent 3b94639 commit ab239d8

30 files changed

+197
-197
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ update( propertyName: string, newValue: any ): void {
101101
// now define and enqueue undo/redo handlers to reverse and redo the commit mutation
102102
enqueueState( propertyName, {
103103
undo(): void {
104-
store.commit( "updateLayerTransformations", { index, opts: { existingValue } });
104+
store.commit( "updateLayerTransform", { index, opts: { existingValue } });
105105
},
106106
redo(): void {
107107
commit();

src/components/document-canvas/decorators/touch-decorator.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default {
2323
},
2424
methods: {
2525
...mapMutations([
26-
"updateLayerTransformations",
26+
"updateLayerTransform",
2727
]),
2828
detectTouch(): void {
2929
this.usesTouch = false;
@@ -127,9 +127,9 @@ export default {
127127
/*
128128
handleRotateGesture( event ) : void{
129129
// TODO: this should go into history
130-
this.updateLayerTransformations({
130+
this.updateLayerTransform({
131131
index: this.activeLayerIndex,
132-
transformations: { rotation: degreesToRadians( event.angle ) }
132+
transform: { rotation: degreesToRadians( event.angle ) }
133133
});
134134
},*/
135135
}

src/components/tool-options-panel/tool-options-mirror/tool-options-mirror.vue

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252

5353
<script lang="ts">
5454
import { mapGetters } from "vuex";
55-
import type { Transformations } from "@/definitions/document";
55+
import type { Transform } from "@/definitions/document";
5656
import { enqueueState } from "@/factories/history-state-factory";
5757
import messages from "./messages.json";
5858
@@ -62,38 +62,38 @@ export default {
6262
...mapGetters([
6363
"activeLayer",
6464
"activeLayerIndex",
65-
"activeLayerTransformations",
65+
"activeLayerTransform",
6666
]),
6767
canReset(): void {
68-
const { mirrorX, mirrorY } = this.activeLayer.transformations;
68+
const { mirrorX, mirrorY } = this.activeLayer.transform;
6969
return mirrorX || mirrorY;
7070
},
7171
},
7272
methods: {
7373
flipHorizontal(): void {
74-
this.update({ mirrorX: !this.activeLayerTransformations.mirrorX }, "mirrorX" );
74+
this.update({ mirrorX: !this.activeLayerTransform.mirrorX }, "mirrorX" );
7575
},
7676
flipVertical(): void {
77-
this.update({ mirrorY: !this.activeLayerTransformations.mirrorY }, "mirrorY" );
77+
this.update({ mirrorY: !this.activeLayerTransform.mirrorY }, "mirrorY" );
7878
},
7979
resetFlip(): void {
8080
this.update({ mirrorX: false, mirrorY: false }, "mirrorXY" );
8181
},
82-
update( transformations: Partial<Transformations>, propName = "mirror" ): void {
83-
const { mirrorX, mirrorY } = this.activeLayerTransformations;
84-
const newTransformations = {
82+
update( transform: Partial<Transform>, propName = "mirror" ): void {
83+
const { mirrorX, mirrorY } = this.activeLayerTransform;
84+
const newTransform = {
8585
mirrorX,
8686
mirrorY,
87-
...transformations,
87+
...transform,
8888
};
8989
const index = this.activeLayerIndex;
9090
const store = this.$store;
91-
const commit = () => store.commit( "updateLayerTransformations", { index, transformations: newTransformations });
91+
const commit = () => store.commit( "updateLayerTransform", { index, transform: newTransform });
9292
commit();
9393
9494
enqueueState( `${propName}_${index}`, {
9595
undo(): void {
96-
store.commit( "updateLayerTransformations", { index, transformations: { mirrorX, mirrorY } });
96+
store.commit( "updateLayerTransform", { index, transform: { mirrorX, mirrorY } });
9797
},
9898
redo: commit,
9999
});

src/components/tool-options-panel/tool-options-rotate/tool-options-rotate.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ export default {
8888
...mapGetters([
8989
"activeLayer",
9090
"activeLayerIndex",
91-
"activeLayerTransformations",
91+
"activeLayerTransform",
9292
]),
9393
// note rotation is stored in radians but represented visually as degrees
9494
rotation: {
9595
get(): number {
96-
return radiansToDegrees( this.activeLayerTransformations.rotation );
96+
return radiansToDegrees( this.activeLayerTransform.rotation );
9797
},
9898
set( value: number ): void {
9999
this.update( degreesToRadians( value % 360 ));
@@ -102,7 +102,7 @@ export default {
102102
},
103103
methods: {
104104
...mapMutations([
105-
"updateLayerTransformations",
105+
"updateLayerTransform",
106106
]),
107107
update( rotation: number ): void {
108108
rotateLayer( this.$store, this.activeLayer, this.activeLayerIndex, rotation );

src/components/tool-options-panel/tool-options-scale/tool-options-scale.vue

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,43 +81,43 @@ export default {
8181
...mapGetters([
8282
"activeLayer",
8383
"activeLayerIndex",
84-
"activeLayerTransformations",
84+
"activeLayerTransform",
8585
]),
8686
scale: {
8787
get(): number {
88-
return ( this.activeLayerTransformations.scale - 1 ) * MAX_ZOOM;
88+
return ( this.activeLayerTransform.scale - 1 ) * MAX_ZOOM;
8989
},
9090
set( value: number ): void {
9191
this.update( scale( value, MAX_ZOOM, 1 ) + 1 );
9292
}
9393
},
9494
isScaled(): boolean {
95-
return this.activeLayerTransformations.scale !== 1;
95+
return this.activeLayerTransform.scale !== 1;
9696
},
9797
isSaveable(): boolean {
9898
return SAVEABLE_TYPES.includes( this.activeLayer?.type );
9999
},
100100
},
101101
methods: {
102102
update( scale: number ): void {
103-
const oldScale = this.activeLayerTransformations.scale;
103+
const oldScale = this.activeLayerTransform.scale;
104104
const index = this.activeLayerIndex;
105105
const store = this.$store;
106106
const commit = () => {
107-
store.commit( "updateLayerTransformations", { index, transformations: { scale } });
107+
store.commit( "updateLayerTransform", { index, transform: { scale } });
108108
};
109109
commit();
110110
enqueueState( `scale_${index}`, {
111111
undo() {
112-
store.commit( "updateLayerTransformations", { index, transformations: { scale: oldScale } });
112+
store.commit( "updateLayerTransform", { index, transform: { scale: oldScale } });
113113
},
114114
redo: commit
115115
});
116116
},
117117
async save(): Promise<void> {
118118
const { activeLayer } = this;
119119
const { left, top, width, height } = activeLayer;
120-
const { scale } = activeLayer.transformations;
120+
const { scale } = activeLayer.transform;
121121
const index = this.activeLayerIndex;
122122
const store = this.$store;
123123
const orgImage = cloneCanvas( this.activeLayer.source );
@@ -139,14 +139,14 @@ export default {
139139
const commit = () => {
140140
store.commit( "updateLayer", { index, opts: { source: scaledImage, left: 0, top: 0, width: targetWidth, height: targetHeight } });
141141
// unset layer scale (the resized image should display at a reset scale)
142-
store.commit( "updateLayerTransformations", { index, transformations: { scale: 1 } });
142+
store.commit( "updateLayerTransform", { index, transform: { scale: 1 } });
143143
getRendererForLayer( activeLayer )?.syncPosition();
144144
};
145145
commit();
146146
enqueueState( `saveScale_${scale}`, {
147147
undo() {
148148
store.commit( "updateLayer", { index, opts: { source: orgImage, left, top, width, height } });
149-
store.commit( "updateLayerTransformations", { index, transformations: { scale } });
149+
store.commit( "updateLayerTransform", { index, transform: { scale } });
150150
getRendererForLayer( activeLayer )?.syncPosition();
151151
},
152152
redo: commit,

src/definitions/document.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ export type Layer = {
3838
transparent: boolean;
3939
source?: HTMLCanvasElement;
4040
mask?: HTMLCanvasElement;
41-
transformations: Transformations;
41+
transform: Transform;
4242
filters: Filters;
4343
text: Text;
4444
};
4545

46-
export type Transformations = {
46+
export type Transform = {
4747
scale: number;
4848
rotation: number;
4949
mirrorX: boolean;

src/definitions/tool-types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export const canDragMask = ( activeLayer?: Layer, activeLayerMask?: HTMLCanvasEl
6161
if ( !activeLayer || !activeLayer?.mask || ( activeLayer.mask !== activeLayerMask )) {
6262
return false;
6363
}
64-
return activeLayer.transformations.rotation === 0;
64+
return activeLayer.transform.rotation === 0;
6565
};
6666

6767
export const TOOL_SRC_MERGED = "Merged"; // constant to define that a tools source context are all layers merged

src/factories/layer-factory.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ import type { Rectangle } from "zcanvas";
2424
import { LayerTypes, DEFAULT_LAYER_NAME, DEFAULT_TEXT_LAYER_NAME } from "@/definitions/layer-types";
2525
import type { Layer } from "@/definitions/document";
2626
import { imageToBase64, base64toCanvas } from "@/utils/canvas-util";
27-
import TransformationsFactory, { type TransformationsProps } from "@/factories/transformations-factory";
27+
import TransformFactory, { type TransformProps } from "@/factories/transform-factory";
2828
import FiltersFactory from "@/factories/filters-factory";
2929
import TextFactory from "@/factories/text-factory";
3030
import type { FiltersProps } from "@/factories/filters-factory";
3131
import type { TextProps } from "@/factories/text-factory";
3232

3333
let UID_COUNTER = 0;
3434

35-
export type LayerProps = Partial<Omit<Layer, "transformations" | "filters" | "text">> & {
36-
transformations?: TransformationsProps;
35+
export type LayerProps = Partial<Omit<Layer, "transform" | "filters" | "text">> & {
36+
transform?: TransformProps;
3737
filters?: FiltersProps;
3838
text?: TextProps;
3939
};
@@ -46,7 +46,7 @@ const LayerFactory = {
4646
name = DEFAULT_LAYER_NAME,
4747
type = LayerTypes.LAYER_GRAPHIC, transparent = true, source = null, mask = null,
4848
left = 0, top = 0, maskX = 0, maskY = 0, width = 1, height = 1, visible = true,
49-
transformations = {}, filters = {}, text = {}
49+
transform = {}, filters = {}, text = {}
5050
}: LayerProps = {}): Layer {
5151
return {
5252
id: `layer_${( ++UID_COUNTER )}`,
@@ -63,7 +63,7 @@ const LayerFactory = {
6363
height,
6464
visible,
6565
text: TextFactory.create( text ),
66-
transformations: TransformationsFactory.create( transformations ),
66+
transform: TransformFactory.create( transform ),
6767
filters: FiltersFactory.create( filters ),
6868
}
6969
},
@@ -86,7 +86,7 @@ const LayerFactory = {
8686
w: layer.width,
8787
h: layer.height,
8888
tx: TextFactory.serialize( layer.text ),
89-
f: TransformationsFactory.serialize( layer.transformations ),
89+
f: TransformFactory.serialize( layer.transform ),
9090
fl: FiltersFactory.serialize( layer.filters ),
9191
v: layer.visible,
9292
};
@@ -114,7 +114,7 @@ const LayerFactory = {
114114
height: layer.h,
115115
visible: layer.v,
116116
text,
117-
transformations: TransformationsFactory.deserialize( layer.f ),
117+
transform: TransformFactory.deserialize( layer.f ),
118118
filters: FiltersFactory.deserialize( layer.fl ),
119119
});
120120
}

src/factories/transformations-factory.ts renamed to src/factories/transform-factory.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
2121
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
2222
*/
23-
import type { Transformations } from "@/definitions/document";
23+
import type { Transform } from "@/definitions/document";
2424

25-
export type TransformationsProps = Partial<Transformations>;
25+
export type TransformProps = Partial<Transform>;
2626

27-
const TransformationsFactory = {
28-
create({ scale = 1, rotation = 0, mirrorX = false, mirrorY = false }: TransformationsProps = {}): Transformations {
27+
const TransformFactory = {
28+
create({ scale = 1, rotation = 0, mirrorX = false, mirrorY = false }: TransformProps = {}): Transform {
2929
return {
3030
scale,
3131
rotation,
@@ -38,7 +38,7 @@ const TransformationsFactory = {
3838
* Saving transformation properties into a simplified JSON structure
3939
* for project storage
4040
*/
41-
serialize( data: Transformations ): any {
41+
serialize( data: Transform ): any {
4242
return {
4343
s: data.scale,
4444
r: data.rotation,
@@ -48,21 +48,21 @@ const TransformationsFactory = {
4848
},
4949

5050
/**
51-
* Creating a new transformations lists from a stored transformation structure
51+
* Creating a new transformations structure from a stored JSON structure
5252
* inside a stored projects layer
5353
*/
54-
deserialize( data: any = {} ): Transformations {
55-
return TransformationsFactory.create({
54+
deserialize( data: any = {} ): Transform {
55+
return TransformFactory.create({
5656
scale : data.s,
5757
rotation : data.r,
5858
mirrorX : data.x,
5959
mirrorY : data.y,
6060
});
6161
}
6262
};
63-
export default TransformationsFactory;
63+
export default TransformFactory;
6464

65-
export const isEqual = ( data: Transformations, dataToCompare?: Transformations ): boolean => {
65+
export const isEqual = ( data: Transform, dataToCompare?: Transform ): boolean => {
6666
if ( !dataToCompare ) {
6767
return false;
6868
}

src/math/point-math.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export const rotatePointers = ( pointers: Point[], layer: Layer, sourceWidth: nu
185185
// we take layer.left instead of bounds.left as it provides the unrotated Layer offset
186186
const { left, top } = layer;
187187
// translate pointer to translated space, when layer is rotated or mirrored
188-
const { mirrorX, mirrorY, rotation } = layer.transformations;
188+
const { mirrorX, mirrorY, rotation } = layer.transform;
189189
return pointers.map( point => {
190190
// translate recorded pointer towards rotated point
191191
// and against layer position

0 commit comments

Comments
 (0)