dns.conf: use built-in 'self' keyword instead of hardcoded IP#19
Open
harreh3iesh wants to merge 1 commit into
Open
dns.conf: use built-in 'self' keyword instead of hardcoded IP#19harreh3iesh wants to merge 1 commit into
harreh3iesh wants to merge 1 commit into
Conversation
fakedns.py already supports 'self' via RuleEngine2._replace_self(), which resolves to the host machine's LAN IP at runtime. Using it means the config works out of the box without any manual editing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
What
One-line change to
dns.conf— replaces the hardcoded IP with theselfkeyword thatfakedns.pyalready supports viaRuleEngine2._replace_self(). It resolves to the host machine's LAN IP at runtime, so the config works out of the box without any manual editing.Why
Every new user has to edit this before anything works. With
selfthey don't have to touch it at all.No changes to
fakedns.pyor any other file — the feature was already there.