IBX-10735: Leverage new Content Type Search API #1730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
force-pushed
the
use-findContentTypes-in-content-type-list
branch
from
e991be0 to
0462d36
Compare
barw4
changed the title
findContentTypes PAPI contract in content type list
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
reviewed
Oct 6, 2025
konradoboza
approved these changes
Oct 6, 2025
tbialcz
approved these changes
Oct 6, 2025
Steveb-p
reviewed
Oct 6, 2025
konradoboza
reviewed
Oct 6, 2025
Steveb-p
approved these changes
Oct 6, 2025
|
|
||
| $adapter = new ContentTypeListAdapter($this->contentTypeService, $languages); | ||
|
|
||
| self::assertEquals( |
Contributor
There was a problem hiding this comment.
Suggested change
| self::assertEquals( | |
| self::assertSame( |
Contributor
Author
There was a problem hiding this comment.
assertSame doesn't seem to work, these won't be exactly the same types?
adamwojs
approved these changes
Oct 7, 2025
barw4
changed the title
pawlakadrian
force-pushed
the
use-findContentTypes-in-content-type-list
branch
from
c3d2767 to
3162c8b
Compare
|
mikadamczyk
approved these changes
Oct 21, 2025
Contributor
|
QA Approved on DXP 4.6.x-dev I made some performance these are the average results for 10 tests. 
|
Contributor
Author
|
As the content type list is already cached for a given group and this list is used in multiple places in the app there is no real advantage of using this new adapter for now, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/core#633
Description:
This PR replaces the old
ArrayAdapterwith a dedicated one that utilizes a newfindContentTypesPAPI contract.For QA:
We need to check whether the content type list behaves exactly the same as before, potentially we could check what's the performance gain.
Documentation: