Skip to content

Commit 8e032a9

Browse files
juskorakatarzynazawadapawlakadrian
authored
Apply suggestions from code review
Co-authored-by: katarzynazawada <[email protected]> Co-authored-by: Adrian Pawlak <[email protected]>
1 parent 2f868e0 commit 8e032a9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

features/standard/ContentTree.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Feature: Content tree basic operations
1313
| Article2 | art2 | root | eng-GB |
1414
| Article3 | art3 | root | eng-GB |
1515
And I am logged as admin
16-
And I'm on Content view Page for "root/art1"
16+
When I'm on Content view Page for "root/art1"
1717
Then Content item "root/art1" exists in Content tree
1818

1919
Scenario: New Content item can be created under chosen nested node

src/lib/Behat/BrowserContext/ContentTreeContext.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ final class ContentTreeContext implements Context
1616
{
1717
private ContentTree $contentTree;
1818

19-
public function __construct(
19+
public function __construct(ContentTree $contentTree)
2020
ContentTree $contentTree
2121
)
2222
{

src/lib/Behat/Component/ContentTree.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use Ibexa\Behat\Browser\Locator\VisibleCSSLocator;
1414
use PHPUnit\Framework\Assert;
1515

16-
class ContentTree extends Component
16+
final class ContentTree extends Component
1717
{
1818
public function verifyIsLoaded(): void
1919
{
@@ -38,7 +38,7 @@ protected function specifyLocators(): array
3838
new VisibleCSSLocator('treeItem', '.c-tb-list-item-single__label'),
3939
new VisibleCSSLocator('treeElement', '.ibexa-content-tree-container__root .c-tb-list-item-single__element'),
4040
new VisibleCSSLocator('search', '.c-tb-search .ibexa-input'),
41-
new VisibleCSSLocator('contextInTree', '.c-tb-list-item-single__link'),
41+
new VisibleCSSLocator('contentItemInTree', '.c-tb-list-item-single__link'),
4242
];
4343
}
4444
}

0 commit comments

Comments
 (0)