Applied review remarks

Author: barw4

src/bundle/Controller/SiteAccess/SiteAccessController.php

@@ -22,10 +22,12 @@ public function __construct(SiteaccessResolverInterface $nonAdminSiteAccessResol
         $this->nonAdminSiteAccessResolver = $nonAdminSiteAccessResolver;
     }
 
-    public function loadNonAdminSiteAccessesForLocation(Location $location): SiteAccessesList
+    public function loadForLocation(Location $location, string $resolverType = 'non_admin'): SiteAccessesList
     {
-        return new SiteAccessesList(
-            $this->nonAdminSiteAccessResolver->getSiteAccessesListForLocation($location)
-        );
+        switch ($resolverType) {
+            default: $siteAccesses = $this->nonAdminSiteAccessResolver->getSiteAccessesListForLocation($location);
+        }
+
+        return new SiteAccessesList($siteAccesses);
     }
 }

src/bundle/Resources/config/routing_rest.yaml

@@ -143,8 +143,8 @@ ibexa.rest.content_type.load_field_definitions_from_expression:
 #
 
 ibexa.rest.site_access.load_for_location:
-    path: /site-access/load-non-admin-for-location/{locationId}
-    controller: 'Ibexa\Bundle\AdminUi\Controller\SiteAccess\SiteAccessController::loadNonAdminSiteAccessesForLocation'
+    path: /site-access/by-location/{locationId}
+    controller: 'Ibexa\Bundle\AdminUi\Controller\SiteAccess\SiteAccessController::loadForLocation'
     methods: [GET]
     options:
         expose: true

src/lib/REST/Output/ValueObjectVisitor/SiteAccess/SiteAccessesListVisitor.php

@@ -26,8 +26,7 @@ public function visit(Visitor $visitor, Generator $generator, $data): void
         foreach ($data->getSiteAccesses() as $siteAccess) {
             $generator->startObjectElement('SiteAccess');
 
-            $generator->startValueElement('name', $siteAccess->name);
-            $generator->endValueElement('name');
+            $generator->valueElement('name', $siteAccess->name);
 
             $generator->endObjectElement('SiteAccess');
         }

tests/integration/REST/GetSiteAccessesListTest.php

@@ -11,7 +11,7 @@
 use Ibexa\Contracts\Test\Rest\Request\Value\EndpointRequestDefinition;
 
 /**
- * Coverage for /site-access/load-non-admin-for-location/{locationId} REST endpoint.
+ * Coverage for /site-access/by-location/{locationId} REST endpoint.
  */
 final class GetSiteAccessesListTest extends BaseAdminUiRestWebTestCase
 {
@@ -44,7 +44,7 @@ protected static function getEndpointsToTest(): iterable
         foreach (self::REQUIRED_FORMATS as $format) {
             yield new EndpointRequestDefinition(
                 'GET',
-                '/api/ibexa/v2/site-access/load-non-admin-for-location/2',
+                '/api/ibexa/v2/site-access/by-location/2?resolver_type=non_admin',
                 'SiteAccessesList',
                 "application/vnd.ibexa.api.SiteAccessesList+$format",
                 ['HTTP_X-SiteAccess' => 'admin'],