Skip to content

Commit 27fedc3

Browse files
author
Daniel Bot
committed
fix: prevent undefined from getting stringified
1 parent ba53a2b commit 27fedc3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/openapi-lambda-adapters.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,13 @@ describe('Adapt axios request/response to AWS Lambda Proxy Event/Response', () =
150150
headers: {
151151
'x-boolean': true,
152152
'x-number': 100,
153+
'x-zero': 0,
153154
'x-object': {
154155
key: 'value'
155156
},
156157
'x-array': ['a', 'b'],
157158
'x-null': null,
159+
'x-undefined': undefined,
158160
'x-string': 'string'
159161
} as unknown as Record<string, string>
160162
}
@@ -169,10 +171,12 @@ describe('Adapt axios request/response to AWS Lambda Proxy Event/Response', () =
169171

170172
expect(event.headers['x-boolean']).toBe('true')
171173
expect(event.headers['x-number']).toBe('100')
174+
expect(event.headers['x-zero']).toBe('0')
172175
expect(event.headers['x-string']).toBe('string')
173176
expect(event.headers['x-object']).toBe('[object Object]')
174177
expect(event.headers['x-array']).toBe('a,b')
175178
expect(event.headers['x-null']).toBeUndefined()
179+
expect(event.headers['x-undefined']).toBeUndefined()
176180
})
177181
})
178182

src/openapi-lambda-adapters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const convertAxiosToApiGw = (config: AxiosRequestConfig, operation: Opera
5454
Object.entries(config.params ?? {}).forEach(([key, val]) => urlSearchParams.append(key, val.toString()))
5555

5656
const headers: Record<string, string> = {}
57-
for (const [key, val] of Object.entries(config.headers ?? {}).filter(([_key, val]) => val !== null)) {
57+
for (const [key, val] of Object.entries(config.headers ?? {}).filter(([_key, val]) => val !== null && val !== undefined)) {
5858
headers[key] = val.toString()
5959
}
6060

0 commit comments

Comments
 (0)