Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

Feedback about diagrams #355

@rootulp

Description

@rootulp

Context

I have some miscelaneous feedback after reading the learn section. Feel free to close if not helpful.

Feedback

  • The architecture diagram here conflicts with the sequence diagram. The architecture diagram looks incorrect because the ISM doesn’t invoke ISM on the recipient. Instead the mailbox does that.
  • In sequence diagram how does the relayer know which ISMs to invoke moduleType() on? Why does it need to do that given it calls process() on the mailbox without the ISM type. Maybe it’s just needed for metadata to process messages? The relayer likely needs a hard-coded list of ISM addresses deployed on each chain if it’s going to query it.
  • In post dispatch how does the postDispatch hook revert if insufficient fees? Fees aren’t a parameter to the postDispatch invocation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions