Skip to content

Release workflow #20

Description

@Seldaek

I looked at this package to try and understand why you got flagged for re-tagging by the new Packagist.org immutable releases (I guess you should have received an email, but anyway now that I researched it I figured I tell you clearly what the problem is).

https://github.com/humanmade/hm-query-loop/blob/main/.github/workflows/release.yml#L50-L52 retags when you create a release it. I think it would be a cleaner workflow to either trigger a tag manually by doing a manual workflow trigger, and have the workflow create the tag + the release.. Or you could push to a release/1.2.3 branch for example and have the build-and-release.yml workflow trigger on that, finalize that release and creating a tag + release out of it. Then you avoid deleting/retagging tags, which is a really bad practice for ecosystem integrity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions