fix(eslint): fix ESLint issues

hckhanh · hckhanh · commit aa6450a9f9f3 · 2021-12-17T19:01:25.000+07:00
diff --git a/.eslintrc b/.eslintrc
@@ -1,8 +1,11 @@
 {
+  "root": true,
   "extends": ["oclif", "oclif-typescript", "plugin:prettier/recommended"],
   "rules": {
-    "quotes": ["error", "double"],
     "no-await-in-loop": "off",
+    "node/no-missing-import": 1,
+    "quotes": ["error", "double"],
+    "unicorn/no-for-loop": "off",
     "unicorn/filename-case": "off"
   }
 }
diff --git a/package.json b/package.json
@@ -72,28 +72,28 @@
     ]
   },
   "dependencies": {
-    "@oclif/command": "^1",
-    "@oclif/config": "^1",
-    "@oclif/plugin-help": "^3",
-    "cli-ux": "^5.5.1",
-    "cross-spawn": "^7.0.3",
-    "ini": "^2.0.0",
-    "inquirer": "^8.0.0",
-    "js-yaml": "^4.0.0",
-    "tslib": "^2.1.0"
+    "@oclif/command": "1.8.15",
+    "@oclif/config": "1.18.2",
+    "@oclif/plugin-help": "5.1.10",
+    "cli-ux": "6.0.6",
+    "cross-spawn": "7.0.3",
+    "ini": "2.0.0",
+    "inquirer": "8.2.0",
+    "js-yaml": "4.1.0",
+    "tslib": "2.3.1"
   },
   "devDependencies": {
     "@oclif/dev-cli": "^1",
     "@types/cross-spawn": "^6",
     "@types/ini": "^1",
     "@types/inquirer": "^7",
     "@types/js-yaml": "^4",
-    "@types/node": "^14",
-    "eslint": "^7.22.0",
-    "eslint-config-oclif": "^3.1",
-    "eslint-config-oclif-typescript": "^0.2.0",
-    "eslint-config-prettier": "^8.1.0",
-    "eslint-plugin-prettier": "^3.3.1",
+    "@types/node": "^16",
+    "eslint": "7.32.0",
+    "eslint-config-oclif": "4.0.0",
+    "eslint-config-oclif-typescript": "1.0.2",
+    "eslint-config-prettier": "8.3.0",
+    "eslint-plugin-prettier": "4.0.0",
     "prettier": "2.5.1",
     "rimraf": "^3.0.2",
     "ts-node": "^9.1.1",
diff --git a/src/actions/AddScriptsAction.ts b/src/actions/AddScriptsAction.ts
@@ -2,7 +2,7 @@ import { formatJson, readContentFromFile, withCurrentDir, writeContentToFile } f
 import { Action } from "./Action";
 
 export class AddScriptsAction extends Action {
-  constructor(private scripts: object, private enable: boolean) {
+  constructor(private scripts: Record<string, unknown>, private enable: boolean) {
     super();
   }
 
diff --git a/src/actions/CreateConfigsFileAction.ts b/src/actions/CreateConfigsFileAction.ts
@@ -3,7 +3,11 @@ import { withCurrentDir, writeContentToFile } from "../process";
 import { Action } from "./Action";
 
 export class CreateConfigsFileAction extends Action {
-  constructor(private fileName: string, private configs: object, private formatter: Formatter) {
+  constructor(
+    private fileName: string,
+    private configs: Record<string, unknown>,
+    private formatter: Formatter,
+  ) {
     super();
   }
 
diff --git a/src/formatters/Formatter.ts b/src/formatters/Formatter.ts
@@ -1,5 +1,5 @@
 export abstract class Formatter {
-  abstract format(configs: object): string;
+  abstract format(configs: Record<string, unknown>): string;
 
   abstract formatFileName(fileName: string): string;
 }
diff --git a/src/formatters/IniFormatter.ts b/src/formatters/IniFormatter.ts
@@ -2,7 +2,7 @@ import { encode } from "ini";
 import { Formatter } from "./Formatter";
 
 export class IniFormatter extends Formatter {
-  format(configs: object) {
+  format(configs: Record<string, unknown>) {
     const iniConfigs = encode(configs);
     return iniConfigs.replace(/\.\*=true/g, ".*");
   }
diff --git a/src/formatters/JsFormatter.ts b/src/formatters/JsFormatter.ts
@@ -1,7 +1,7 @@
 import { JsonFormatter } from "./JsonFormatter";
 
 export class JsFormatter extends JsonFormatter {
-  format(configs: object) {
+  format(configs: Record<string, unknown>) {
     const jsonObj = super.format(configs);
     return "module.exports = ".concat(jsonObj);
   }
diff --git a/src/formatters/JsonFormatter.ts b/src/formatters/JsonFormatter.ts
@@ -2,7 +2,7 @@ import { formatJson } from "../process";
 import { Formatter } from "./Formatter";
 
 export class JsonFormatter extends Formatter {
-  format(configs: object) {
+  format(configs: Record<string, unknown>) {
     return formatJson(configs);
   }
 
diff --git a/src/formatters/YamlFormatter.ts b/src/formatters/YamlFormatter.ts
@@ -2,7 +2,7 @@ import { dump } from "js-yaml";
 import { Formatter } from "./Formatter";
 
 export class YamlFormatter extends Formatter {
-  format(configs: object) {
+  format(configs: Record<string, unknown>) {
     return dump(configs);
   }
 
diff --git a/src/generators/ESLintGenerator.ts b/src/generators/ESLintGenerator.ts
@@ -10,7 +10,7 @@ import type { InquirerConfigs } from "../types";
 import { Generator } from "./Generator";
 
 export class ESLintGenerator extends Generator {
-  generateConfigs(userConfigs: InquirerConfigs): [object, string[]] {
+  generateConfigs(userConfigs: InquirerConfigs): [Record<string, unknown>, string[]] {
     const configs: any = eslintBaseConfigs;
     const packages = ["eslint"];
 
@@ -66,7 +66,7 @@ export class ESLintGenerator extends Generator {
   }
 
   initActions(
-    configs: object,
+    configs: Record<string, unknown>,
     packages: string[],
     userConfigs: InquirerConfigs,
     formatter: Formatter,
diff --git a/src/generators/FlowGenerator.ts b/src/generators/FlowGenerator.ts
@@ -11,7 +11,7 @@ import type { InquirerConfigs } from "../types";
 import { Generator } from "./Generator";
 
 export class FlowGenerator extends Generator {
-  generateConfigs(userConfigs: InquirerConfigs): [object, string[]] {
+  generateConfigs(userConfigs: InquirerConfigs): [Record<string, unknown>, string[]] {
     const configs: any = { ...flowConfigs };
     const packages = ["flow-bin", "flow-typed"];
 
@@ -24,7 +24,7 @@ export class FlowGenerator extends Generator {
   }
 
   initActions(
-    configs: object,
+    configs: Record<string, unknown>,
     packages: string[],
     userConfigs: InquirerConfigs,
     formatter: Formatter,
diff --git a/src/generators/Generator.ts b/src/generators/Generator.ts
@@ -11,10 +11,10 @@ export abstract class Generator {
     this.actions = this.initActions(configs, packages, userConfigs, formatter, packager);
   }
 
-  abstract generateConfigs(userConfigs: InquirerConfigs): [object, string[]];
+  abstract generateConfigs(userConfigs: InquirerConfigs): [Record<string, unknown>, string[]];
 
   abstract initActions(
-    configs: object,
+    configs: Record<string, unknown>,
     packages: string[],
     userConfigs: InquirerConfigs,
     formatter: Formatter,
diff --git a/src/generators/PostGenerator.ts b/src/generators/PostGenerator.ts
@@ -7,16 +7,16 @@ import type { InquirerConfigs } from "../types";
 import { Generator } from "./Generator";
 
 export class PostGenerator extends Generator {
-  generateConfigs(userConfigs: InquirerConfigs): [object, string[]] {
+  generateConfigs(_userConfigs: InquirerConfigs): [Record<string, unknown>, string[]] {
     return [{}, []];
   }
 
   initActions(
-    configs: object,
-    packages: string[],
-    userConfigs: InquirerConfigs,
-    formatter: Formatter,
-    packager: Packager,
+    _configs: Record<string, unknown>,
+    _packages: string[],
+    _userConfigs: InquirerConfigs,
+    _formatter: Formatter,
+    _packager: Packager,
   ): Action[] {
     return [new CreateFileAction(".gitignore", postIgnoreFiles)];
   }
diff --git a/src/generators/PrettierGenerator.ts b/src/generators/PrettierGenerator.ts
@@ -10,12 +10,12 @@ import type { InquirerConfigs } from "../types";
 import { Generator } from "./Generator";
 
 export class PrettierGenerator extends Generator {
-  generateConfigs(userConfigs: InquirerConfigs): [object, string[]] {
+  generateConfigs(_userConfigs: InquirerConfigs): [Record<string, unknown>, string[]] {
     return [prettierConfigs, ["prettier"]];
   }
 
   initActions(
-    configs: object,
+    configs: Record<string, unknown>,
     packages: string[],
     userConfigs: InquirerConfigs,
     formatter: Formatter,
diff --git a/src/generators/Yarn2Generator.ts b/src/generators/Yarn2Generator.ts
@@ -7,15 +7,15 @@ import type { InquirerConfigs } from "../types";
 import { Generator } from "./Generator";
 
 export class Yarn2Generator extends Generator {
-  generateConfigs(userConfigs: InquirerConfigs): [object, string[]] {
+  generateConfigs(_userConfigs: InquirerConfigs): [Record<string, unknown>, string[]] {
     return [{}, []];
   }
 
   initActions(
-    configs: object,
-    packages: string[],
+    _configs: Record<string, unknown>,
+    _packages: string[],
     userConfigs: InquirerConfigs,
-    formatter: Formatter,
+    _formatter: Formatter,
   ): Action[] {
     return [
       new CreateYarn2ConfigsAction(userConfigs),
diff --git a/src/process.ts b/src/process.ts
@@ -1,8 +1,8 @@
-import type { ChildProcessWithoutNullStreams } from "child_process";
+import type { ChildProcessWithoutNullStreams } from "node:child_process";
 import { spawn } from "cross-spawn";
-import { readdir, readFile, rm, stat, writeFile } from "fs/promises";
+import { readdir, readFile, rm, stat, writeFile } from "node:fs/promises";
 import type { Stats } from "node:fs";
-import { join } from "path";
+import { join } from "node:path";
 
 export const currentDir = process.cwd();
 
@@ -87,6 +87,6 @@ export async function readCurrentDir() {
   return readdir(currentDir, { withFileTypes: true });
 }
 
-export function formatJson(obj: object): string {
+export function formatJson(obj: Record<string, unknown>): string {
   return JSON.stringify(obj, null, 2);
 }
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,11 @@`
`1`	`1`	`{`
	`2`	`+ "root": true,`
`2`	`3`	`"extends": ["oclif", "oclif-typescript", "plugin:prettier/recommended"],`
`3`	`4`	`"rules": {`
`4`		`- "quotes": ["error", "double"],`
`5`	`5`	`"no-await-in-loop": "off",`
	`6`	`+ "node/no-missing-import": 1,`
	`7`	`+ "quotes": ["error", "double"],`
	`8`	`+ "unicorn/no-for-loop": "off",`
`6`	`9`	`"unicorn/filename-case": "off"`
`7`	`10`	`}`
`8`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { formatJson, readContentFromFile, withCurrentDir, writeContentToFile } f`
`2`	`2`	`import { Action } from "./Action";`
`3`	`3`
`4`	`4`	`export class AddScriptsAction extends Action {`
`5`		`- constructor(private scripts: object, private enable: boolean) {`
	`5`	`+ constructor(private scripts: Record<string, unknown>, private enable: boolean) {`
`6`	`6`	`super();`
`7`	`7`	`}`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`export abstract class Formatter {`
`2`		`- abstract format(configs: object): string;`
	`2`	`+ abstract format(configs: Record<string, unknown>): string;`
`3`	`3`
`4`	`4`	`abstract formatFileName(fileName: string): string;`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { encode } from "ini";`
`2`	`2`	`import { Formatter } from "./Formatter";`
`3`	`3`
`4`	`4`	`export class IniFormatter extends Formatter {`
`5`		`- format(configs: object) {`
	`5`	`+ format(configs: Record<string, unknown>) {`
`6`	`6`	`const iniConfigs = encode(configs);`
`7`	`7`	`return iniConfigs.replace(/\.\=true/g, ".");`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { JsonFormatter } from "./JsonFormatter";`
`2`	`2`
`3`	`3`	`export class JsFormatter extends JsonFormatter {`
`4`		`- format(configs: object) {`
	`4`	`+ format(configs: Record<string, unknown>) {`
`5`	`5`	`const jsonObj = super.format(configs);`
`6`	`6`	`return "module.exports = ".concat(jsonObj);`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { formatJson } from "../process";`
`2`	`2`	`import { Formatter } from "./Formatter";`
`3`	`3`
`4`	`4`	`export class JsonFormatter extends Formatter {`
`5`		`- format(configs: object) {`
	`5`	`+ format(configs: Record<string, unknown>) {`
`6`	`6`	`return formatJson(configs);`
`7`	`7`	`}`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { dump } from "js-yaml";`
`2`	`2`	`import { Formatter } from "./Formatter";`
`3`	`3`
`4`	`4`	`export class YamlFormatter extends Formatter {`
`5`		`- format(configs: object) {`
	`5`	`+ format(configs: Record<string, unknown>) {`
`6`	`6`	`return dump(configs);`
`7`	`7`	`}`
`8`	`8`