Unneeded release artifacs generated by release script

[ffaf1]

Describe the bug
When going through “Publishing the artifacts” in “Making a release”, I noticed CI added source code for a number of packages we do not release, like cabal-benchmarks.

To Reproduce
Tag, wait for artifacts, check the “Assets” list.

Expected behavior
Just release what needed: Cabal, Cabal-syntax, Cabal-hooks, cabal-install-solver, cabal-install, hooks-exe. Plus the binaries, of course.

System information
N/A

Additional context
N/A

[ulysses4ever]

@hasufell maybe?

[Bodigrim]

It depends. Say, it's not unreasonable to package Cabal-testsuite even while it is not published on Hackage. Because a distributor might want to run tests after building from sources and in the absense of Cabal-testsuite would not be able to do so.

In principle the same is true for cabal-benchmarks: a distributor might want to run benchmarks, which we used by releasers to sign off the release.

[ulysses4ever]

I d prefer tidier release pages. If someone loves cabal-testsuite, they should shout and we can add it. (AFAIK is tricky to stop is you funny use the repo) By default I'd prefer only stuff that goes to Hackage.

[hasufell]

Why are those packages not on hackage?

[ulysses4ever]

why would they be? not all haskell packages on planet earth are suited for hackage. e.g. packages that are intended for internal use by a project. It'd be wasteful---both in terms of our time and Hackage resourse---to share what we consider useless for general paublic.

[hasufell]

I don't follow that argument.

Tests and benchmarks are usually part of a cabal package. Here they are separate. So why would they not be uploaded?

[hasufell]

Since when are testsuites "internal to the project"? End users want to run tests in their environment too.