Skip to content

Teams SSH doesn't update existing users' SSH keys #1

@toBeOfUse

Description

@toBeOfUse

If someone is added to the Sudo or SSH teams in the HacKSU org, and later adds SSH key(s) to their account in order to log in to a server, the new keys will not be added to their .ssh/authorized_keys file, since that file is only updated when the user account is initially added to the server.

This can be worked around by removing a user from both the SSH and, if necessary, the Sudo team, waiting for teams-ssh to update, and then re-adding them and waiting for teams-ssh to update again.

Fixing this would require pulling each user's SSH keys along with their team membership from Github every 60 seconds, checking if each key is already present in the authorized_keys file or not, and adding it if it isn't already there.

Automatically removing keys when they're removed from a user's Github profile could be more problematic. It would increase the security of the system by providing a quick way to remove keys if they're compromised, but it could also lead to unexpected lockouts if the user uses an SSH key for their server account without even realizing it's also saved in their Github account.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions