-
Notifications
You must be signed in to change notification settings - Fork 733
Fixes #2404. Add OpenMenu() methods to MenuBar for dropdown list usage #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2_develop
Are you sure you want to change the base?
Conversation
Co-authored-by: tig <[email protected]>
Co-authored-by: tig <[email protected]>
Co-authored-by: tig <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v2_develop #4412 +/- ##
===============================================
- Coverage 77.45% 66.34% -11.12%
===============================================
Files 386 388 +2
Lines 44585 44644 +59
Branches 6272 6282 +10
===============================================
- Hits 34533 29618 -4915
- Misses 8206 13103 +4897
- Partials 1846 1923 +77
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@copilot Investigate and fix the failing integration and unit tests. |
Co-authored-by: tig <[email protected]>
Fixed in commit 854a095. The test compilation errors were caused by using
|
|
@copilot here's my git remote -v: git remote -v Help me pull this down locally. git checkout copilot/enable-menubar-replacement says: git checkout copilot/enable-menubar-replacement |
Based on your remotes, the branch is on the git fetch copilot
git checkout --track copilot/copilot/enable-menubar-replacementOr if you want to check it out with a different local name: git checkout -b enable-menubar-replacement copilot/copilot/enable-menubar-replacementThis will create a local branch tracking the remote branch from the |
Simple prototype for now
Refactored `DropDownListExample` for modularity and lifecycle management. Introduced `PopoverWrapper<TView>` to enable any `View` to function as a popover, along with `ViewPopoverExtensions` for a fluent API. Added `PopoverWrapperExample` project to demonstrate usage with examples like `ListView`, forms, and `ColorPicker`. Enhanced `Shortcut` class with a configurable `MarginThickness` property. Updated `PopoverBaseImpl` to redraw UI on visibility changes. Added comprehensive unit tests for `PopoverWrapper` and extensions. Updated `Terminal.sln` to include the new project. Added detailed documentation in `README.md`. Improved code maintainability, modularity, and user experience.
Fixes
Proposed Changes/Todos
OpenMenu()method to programmatically open first menu itemOpenMenu(Point?)overload for custom positioningChanges
Public API Additions
MenuBar.OpenMenu()boolindicating successMenuBar.OpenMenu(Point? position)nullImplementation
Modified
ShowItem()to accept optionalPoint? positionparameter. When provided, positions PopoverMenu at specified coordinates instead of default MenuBarItem bottom-left.Documentation
Added class-level example showing TextField + MenuBar dropdown pattern:
Bug Fixes
Fixed compilation errors in test methods by using
new Runnable()instead ofnew Toplevel()to align with the existing test pattern in MenuBarTests class.Notes
Menu.OnVisibleChanged- no fix neededMenuBar.DefaultBorderStylealreadyLineStyle.None- clean appearance by defaultPull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.