-
Notifications
You must be signed in to change notification settings - Fork 23
fix: sbom-details show supplier and author #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Carlos Feria <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the SBOM details view to align terminology and data with requirements by renaming the creator field to supplier, displaying suppliers/authors as comma‑separated lists, and updating the related UI test expectation. Class diagram for SBOM details overview component changesclassDiagram
class Overview {
+render(sbom)
}
class Sbom {
+suppliers string[]
+authors string[]
}
Overview --> Sbom : displays_details_for
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- When using
sbom.suppliers.join()andsbom.authors.join(), consider defensively handling cases where these fields might be undefined, null, or not arrays (e.g., defaulting to an empty array or string) to avoid runtime errors and better match the previous, more permissive rendering behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When using `sbom.suppliers.join()` and `sbom.authors.join()`, consider defensively handling cases where these fields might be undefined, null, or not arrays (e.g., defaulting to an empty array or string) to avoid runtime errors and better match the previous, more permissive rendering behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes https://issues.redhat.com/browse/TC-2444
SBOM Details Page:
CreatorbySupplier. This also helps consistency as the SBOM List page calls themSupplierAuthorfield so that info is rendered as requested in the JIRA https://issues.redhat.com/browse/TC-2444Summary by Sourcery
Update SBOM details view to display supplier and author information consistently with SBOM list.
New Features:
Enhancements:
Tests: