Skip to content

Conversation

@carlosthe19916
Copy link
Collaborator

@carlosthe19916 carlosthe19916 commented Nov 25, 2025

Fixes https://issues.redhat.com/browse/TC-2444

SBOM Details Page:

  • Rename Creator by Supplier. This also helps consistency as the SBOM List page calls them Supplier
  • Add the Author field so that info is rendered as requested in the JIRA https://issues.redhat.com/browse/TC-2444
image

Summary by Sourcery

Update SBOM details view to display supplier and author information consistently with SBOM list.

New Features:

  • Display SBOM author information on the SBOM details page.

Enhancements:

  • Rename the SBOM details field from creator to supplier and render multiple suppliers as a comma-separated list for consistency across views.

Tests:

  • Adjust SBOM explorer UI feature test to assert visibility of the supplier field instead of creator.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the SBOM details view to align terminology and data with requirements by renaming the creator field to supplier, displaying suppliers/authors as comma‑separated lists, and updating the related UI test expectation.

Class diagram for SBOM details overview component changes

classDiagram
  class Overview {
    +render(sbom)
  }

  class Sbom {
    +suppliers string[]
    +authors string[]
  }

  Overview --> Sbom : displays_details_for
Loading

File-Level Changes

Change Details Files
Update SBOM details overview to show suppliers and authors as separate, comma-separated fields with corrected labels and aria attributes.
  • Rename the Creator label to Supplier to match SBOM list terminology and requirements.
  • Render suppliers as a comma-separated list using the suppliers array rather than the raw value.
  • Add a new Author field that renders authors as a comma-separated list from the authors array.
  • Adjust aria-labels for the supplier and author description elements to reflect the new labels.
client/src/app/pages/sbom-details/overview.tsx
Align end-to-end UI test expectations with the updated SBOM details terminology.
  • Update the SBOM Explorer feature test to expect the Supplier label instead of Creator on the SBOM details page.
e2e/tests/ui/features/@sbom-explorer/sbom-explorer.feature

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • When using sbom.suppliers.join() and sbom.authors.join(), consider defensively handling cases where these fields might be undefined, null, or not arrays (e.g., defaulting to an empty array or string) to avoid runtime errors and better match the previous, more permissive rendering behavior.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- When using `sbom.suppliers.join()` and `sbom.authors.join()`, consider defensively handling cases where these fields might be undefined, null, or not arrays (e.g., defaulting to an empty array or string) to avoid runtime errors and better match the previous, more permissive rendering behavior.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant