Fix bug in handling Session Keys

simo5 · simo5 · commit 93fe956a5e4e · 2015-09-03T12:59:46.000-04:00
A check inversion in 86661d0 caused the specified session key to be ignored and a crash when none was specified. Signed-off-by: Simo Sorce <simo@redhat.com>
diff --git a/src/mod_auth_gssapi.c b/src/mod_auth_gssapi.c
@@ -648,7 +648,7 @@ struct mag_req_cfg *mag_init_cfg(request_rec *req)
         req_cfg->desired_mechs = scfg->default_mechs;
     }
 
-    if (!req_cfg->cfg->mag_skey) {
+    if (req_cfg->cfg->mag_skey) {
         req_cfg->mag_skey = req_cfg->cfg->mag_skey;
     } else {
         /* Use server random key if not explicitly configured */

Original file line number	Diff line number	Diff line change
`@@ -648,7 +648,7 @@ struct mag_req_cfg mag_init_cfg(request_rec req)`
`648`	`648`	`req_cfg->desired_mechs = scfg->default_mechs;`
`649`	`649`	`}`
`650`	`650`
`651`		`- if (!req_cfg->cfg->mag_skey) {`
	`651`	`+ if (req_cfg->cfg->mag_skey) {`
`652`	`652`	`req_cfg->mag_skey = req_cfg->cfg->mag_skey;`
`653`	`653`	`} else {`
`654`	`654`	`/* Use server random key if not explicitly configured */`