Skip to content

Commit a747df5

Browse files
committed
directionCollideCoverage() tweaks
* fix #2435 moved overMax outside of loop.
1 parent 87cdedb commit a747df5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/gridstack-engine.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,11 @@ export class GridStackEngine {
159159
}
160160

161161
let collide: GridStackNode;
162+
let overMax = 0.5; // need >50%
162163
collides.forEach(n => {
163164
if (n.locked || !n._rect) return;
164165
let r2 = n._rect; // overlapping target
165-
let yOver = Number.MAX_VALUE, xOver = Number.MAX_VALUE, overMax = 0.5; // need >50%
166+
let yOver = Number.MAX_VALUE, xOver = Number.MAX_VALUE;
166167
// depending on which side we started from, compute the overlap % of coverage
167168
// (ex: from above/below we only compute the max horizontal line coverage)
168169
if (r0.y < r2.y) { // from above

0 commit comments

Comments
 (0)