fix: set BackoffLimit to zero for starter and stopper jobs to prevent excessive pod creation (#659)

* fix: set BackoffLimit to zero for starter job to prevent excessive pod creation

* test: set BackoffLimit to 0 for starter and stopper job tests

Author: moko-poi

pkg/resources/jobs/starter.go

@@ -62,6 +62,8 @@ func NewStarterJob(k6 *v1alpha1.TestRun, hostname []string) *batchv1.Job {
 		resourceRequirements = k6.GetSpec().Starter.Resources
 	}
 
+	var zero32 int32
+
 	return &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:        fmt.Sprintf("%s-starter", k6.NamespacedName().Name),
@@ -70,6 +72,7 @@ func NewStarterJob(k6 *v1alpha1.TestRun, hostname []string) *batchv1.Job {
 			Annotations: starterAnnotations,
 		},
 		Spec: batchv1.JobSpec{
+			BackoffLimit: &zero32,
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels:      starterLabels,

pkg/resources/jobs/starter_test.go

@@ -15,6 +15,7 @@ import (
 func TestNewStarterJob(t *testing.T) {
 
 	automountServiceAccountToken := true
+	zero := int32(0)
 
 	expectedOutcome := &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
@@ -30,6 +31,7 @@ func TestNewStarterJob(t *testing.T) {
 			},
 		},
 		Spec: batchv1.JobSpec{
+			BackoffLimit: &zero,
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{
@@ -106,6 +108,7 @@ func TestNewStarterJob(t *testing.T) {
 func TestNewStarterJobIstio(t *testing.T) {
 
 	automountServiceAccountToken := true
+	zero := int32(0)
 
 	expectedOutcome := &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
@@ -121,6 +124,7 @@ func TestNewStarterJobIstio(t *testing.T) {
 			},
 		},
 		Spec: batchv1.JobSpec{
+			BackoffLimit: &zero,
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{

pkg/resources/jobs/stopper_test.go

@@ -13,6 +13,7 @@ import (
 
 func TestNewStopperJob(t *testing.T) {
 	automountServiceAccountToken := true
+	zero := int32(0)
 
 	expectedOutcome := &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
@@ -28,6 +29,7 @@ func TestNewStopperJob(t *testing.T) {
 			},
 		},
 		Spec: batchv1.JobSpec{
+			BackoffLimit: &zero,
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{
@@ -93,6 +95,7 @@ func TestNewStopperJob(t *testing.T) {
 
 func TestNewStopJobIstio(t *testing.T) {
 	automountServiceAccountToken := true
+	zero := int32(0)
 
 	expectedOutcome := &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
@@ -108,6 +111,7 @@ func TestNewStopJobIstio(t *testing.T) {
 			},
 		},
 		Spec: batchv1.JobSpec{
+			BackoffLimit: &zero,
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{