fix: Update Strava cookie format to semicolon-delimited string

- Changed STRAVA_COOKIES from JSON to semicolon-delimited string format
- Updated cookie parsing to handle browser-native format: 'key1=value1; key2=value2'
- Enhanced error messages with expected format examples
- Added cookie count logging for debugging
- Updated documentation with correct cookie examples

This matches the actual cookie format copied from browser DevTools,
making it easier for users to set up integration tests.

Author: gradrix

docs/STRAVA_INTEGRATION_TESTING.md

@@ -22,29 +22,29 @@ This project includes both **unit tests** (mocked) and **optional integration te
 
 ## Running Integration Tests
 
-### Option 1: Environment Variables
+### Option 1: Environment Variables (Temporary)
 
 ```bash
-# Set credentials as environment variables
-export STRAVA_COOKIES='{"strava_session": "your_session_cookie"}'
-export STRAVA_TOKEN='your_csrf_token'
+# Set credentials for this session (cookie string format from browser)
+export STRAVA_COOKIES='_strava4_session=your_session_value; other_cookie=value'
+export STRAVA_TOKEN='your_csrf_token_here'
 
 # Run integration tests
 pytest -v -m requires_strava_auth
 ```
 
-### Option 2: Hardcoded Test Credentials (Development)
+### Option 2: Environment Variables in .env File (Local Development)
 
-Edit `neural_engine/tests/conftest.py` and add:
-
-```python
-# conftest.py
-import os
-
-# Optional: Add your real Strava credentials here for local testing
-# WARNING: Don't commit real credentials! Add conftest.py to .gitignore
-TEST_STRAVA_COOKIES = os.getenv('STRAVA_COOKIES', None)
-TEST_STRAVA_TOKEN = os.getenv('STRAVA_TOKEN', None)
+```bash
+# Create .env file (add to .gitignore!)
+cat > .env << 'EOF'
+STRAVA_COOKIES='_strava4_session=your_session_value; other_cookie=value'
+STRAVA_TOKEN='your_csrf_token'
+EOF
+
+# Load and run tests
+source .env
+pytest -v -m requires_strava_auth
 ```
 
 ### Option 3: Store in KeyValueStore (Persistent)
@@ -54,7 +54,8 @@ TEST_STRAVA_TOKEN = os.getenv('STRAVA_TOKEN', None)
 python3 -c "
 from neural_engine.core.key_value_store import KeyValueStore
 kv = KeyValueStore()
-kv.set('strava_cookies', {'strava_session': 'your_session_cookie'})
+# Store as semicolon-delimited string (as copied from browser)
+kv.set('strava_cookies', '_strava4_session=your_session_value; other_cookie=value')
 kv.set('strava_token', 'your_csrf_token')
 print('Credentials stored!')
 "
@@ -87,13 +88,12 @@ pytest -v -m requires_strava_auth
 
 ### Example Credentials Format
 
-```json
-{
-  "cookies": {
-    "strava_session": "ey1234567890abcdef..."
-  },
-  "token": "csrf_token_value_here"
-}
+```bash
+# Cookies (semicolon-delimited string as copied from browser)
+STRAVA_COOKIES='_strava4_session=a1b2c3d4e5f6...; CloudFront-Policy=eyJ...; CloudFront-Signature=abc...'
+
+# CSRF Token (string)
+STRAVA_TOKEN='xyz123abc456...'
 ```
 
 ## Security Notes

neural_engine/tests/test_strava_auth_flow.py

@@ -167,20 +167,33 @@ def real_credentials(self, kv_store):
         1. Environment variables (STRAVA_COOKIES, STRAVA_TOKEN)
         2. Existing KeyValueStore credentials
         3. Skip test if neither available
+        
+        STRAVA_COOKIES format: Semicolon-delimited string as copied from browser
+        Example: '_strava4_session=abc123; CloudFront-Policy=xyz; CloudFront-Signature=def'
         """
         # Try environment variables first
         cookies_env = os.getenv('STRAVA_COOKIES')
         token_env = os.getenv('STRAVA_TOKEN')
 
         if cookies_env and token_env:
-            # Parse JSON from environment
+            # Parse semicolon-delimited cookie string into dict
             try:
-                cookies = json.loads(cookies_env) if isinstance(cookies_env, str) else cookies_env
+                cookies = {}
+                for cookie_pair in cookies_env.split(';'):
+                    cookie_pair = cookie_pair.strip()
+                    if '=' in cookie_pair:
+                        key, value = cookie_pair.split('=', 1)
+                        cookies[key.strip()] = value.strip()
+                
+                if not cookies:
+                    pytest.skip("STRAVA_COOKIES is empty or invalid format. Expected: 'key1=value1; key2=value2'")
+                
                 kv_store.set("strava_cookies", cookies)
                 kv_store.set("strava_token", token_env)
                 print(f"\n✓ Using Strava credentials from environment variables")
-            except json.JSONDecodeError as e:
-                pytest.skip(f"Invalid JSON in STRAVA_COOKIES environment variable: {e}")
+                print(f"  Parsed {len(cookies)} cookie(s): {list(cookies.keys())}")
+            except Exception as e:
+                pytest.skip(f"Failed to parse STRAVA_COOKIES: {e}. Expected format: 'key1=value1; key2=value2'")
         else:
             # Try existing credentials in KeyValueStore
             existing_cookies = kv_store.get("strava_cookies")
@@ -190,8 +203,6 @@ def real_credentials(self, kv_store):
                 print(f"\n✓ Using existing Strava credentials from KeyValueStore")
             else:
                 pytest.skip(
-                    "Real Strava credentials not provided. "
-                    "Set STRAVA_COOKIES and STRAVA_TOKEN environment variables, "
                     "Real Strava credentials not provided. "
                     "Set STRAVA_COOKIES and STRAVA_TOKEN environment variables, "
                     "or see docs/STRAVA_INTEGRATION_TESTING.md for setup instructions."